Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General | Remove /DietPi/dietpi/.version from GitHub repo #2555

Merged
merged 3 commits into from
Feb 17, 2019
Merged

General | Remove /DietPi/dietpi/.version from GitHub repo #2555

merged 3 commits into from
Feb 17, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Feb 16, 2019 •
edited
Loading

Status: Testing

  • DietPi-Update
  • DietPi-PREP

Commit list/description:

  • General | Remove last dot file from GitHub repo, so we don't need to remove it in dietpi-update or take care it matches upstream version

@MichaIng
v6.22
d3459e5 
+ General | Remove last dot file from GitHub repo, so we don't need to remove it in dietpi-update or take care it matches upstream version
@MichaIng MichaIng self-assigned this Feb 16, 2019
@MichaIng MichaIng added this to the v6.22 milestone Feb 16, 2019
@MichaIng
v6.22
3dc62bd 
+ DietPi-Update | All dot files have been removed from update archive dietpi/ sub dir
@MichaIng
v6.22
f38f324 
+ DietPi-PREP | Use G_GITBRANCH/G_GITOWNER to match/override dietpi-globals defaults
+ DietPi-PREP | Read installed version string to G_* variables from "server_version-6", before removing it, instead of downloading ".version" separately.
+ DietPi-PREP | The above allows to successfully use G_VERSIONDB_SAVE without having ".version" stored in our Git repo
@MichaIng MichaIng requested a review from Fourdee February 16, 2019 16:12
@Fourdee
Copy link
Collaborator

Fourdee commented Feb 17, 2019

@MichaIng

Many thanks 👍

Will merge for testing.

@Fourdee Fourdee merged commit 3820a33 into dev Feb 17, 2019
@MichaIng MichaIng deleted the remove_last_dotfile branch February 17, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fourdee Fourdee Awaiting requested review from Fourdee

Assignees

@MichaIng MichaIng

Labels
Enhancement 💨
Projects
None yet
Milestone
v6.22
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaIng @Fourdee