Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Globals | G_AG*: Remove potentially harmful force options + other enhancements #2572

Merged
merged 2 commits into from
Feb 23, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Feb 20, 2019

Status: Testing

Commit list/description:

  • DietPi-Globals | G_AG*: Remove --allow-downgrades/remove-essential/unauthenticated, since these cases are mostly harmful
  • DietPi-Globals | G_AG*: Use "G_DIETPI-NOTIFY 2 '\e[0m" for initial info print to still force white text in contrast to apt-get output
  • DietPi-Globals | G_AG*: Do not create input string array, since "for i in $string" has exactly the same result
  • DietPi-Globals | G_AG*: "-qq" includes "-y"
  • DietPi-Globals | G_AG*: Reorder apt-get command and options to have consistent "apt-get [] []"
  • DietPi-Globals | G_AG*: No colour reset required after apt-get output, since G_ERROR_HANDLER implies this
  • DietPi-Globals | G_AG*: Add "-q(q)" to certain commands to reduce processing output a bid

Testing:

  • VM Jessie
  • VM Stretch
  • VM Buster

@Fourdee
I know this might break automation in some cases. However I am not keen to automate such potentially harmful APT steps. I prefer to clean up/solve cases where this then fails.

  • For all APT repos we add, a key should be added as well to allow verifying authenticity.
  • Essential packages should be never removed of course.
  • Downgrades should be never automated, if this is attempted, then something with the packages we attempt to install is wrong and we should fix.
  • Only hold states we should keep overriding via G_AGI and G_AGDUG, as legacy or user hold states can break installs. We require/expect latest packages in every case.

On Jessie, no separate hold state options exist. This means that in this case hold states will break APT. But since this should without manual user action never happen and the remaining Jessie systems is less 1%, I think this is acceptable now.

+ DietPi-Globals | G_AG*: Remove --allow-downgrades/remove-essential/unauthenticated, since these cases are mostly harmful
+ DietPi-Globals | G_AG*: Use "G_DIETPI-NOTIFY 2 '\e[0m" for initial info print to still force white text in contrast to apt-get output
+ DietPi-Globals | G_AG*: Do not create input string array, since "for i in $string" has exactly the same result
+ DietPi-Globals | G_AG*: "-qq" includes "-y"
+ DietPi-Globals | G_AG*: Reorder apt-get command and options to have consistent "apt-get [<options>] <command> [<pkgs>]"
+ DietPi-Globals | G_AG*: No colour reset required after apt-get output, since G_ERROR_HANDLER implies this
+ DietPi-Globals | G_AG*: Add "-q(q)" to certain commands to reduce processing output a bid
@MichaIng MichaIng added this to the v6.22 milestone Feb 20, 2019
@MichaIng MichaIng self-assigned this Feb 20, 2019
@MichaIng MichaIng requested a review from Fourdee February 20, 2019 23:32
+ DietPi-Globals | G_AG* : Tiny
@MichaIng MichaIng merged commit 0f3d701 into dev Feb 23, 2019
@MichaIng MichaIng deleted the apt branch February 23, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant