Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DietPi-Software | O!MPD: Install current master + fixes #2884

Merged
merged 17 commits into from
Jun 4, 2019
Merged

DietPi-Software | O!MPD: Install current master + fixes #2884

merged 17 commits into from
Jun 4, 2019

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Jun 2, 2019 •
edited
Loading

Status: Ready

Reference:

Commit list/description:

  • DietPi-Software | O!MPD: Set "server.stream-response-body = 1" with Lighttpd to resolve database update loop
  • DietPi-Software | O!MPD: Install current version from master branch, which fixes a bug with Buster Lighttpd on "Now Playing" page as well. After next official release, revert to latest release from: https://api.github.com/repos/ArturSierzant/OMPD/releases/latest
  • DietPi-Software | O!MPD: Apply Lighttpd drop-in config to solve database update loop: DietPi-Software | O!MPD/myMPD: Database update fails on current upstream versions #2156
  • DietPi-Software | Use userdata subdir variables, as we already have them
  • DietPi-Software | O!MPD: Install dependencies for YouTube and Tidal support. Python is installed with MPD anyway so it is minimal overhead for users that do not require it.

@MichaIng
v6.25
0d3dfdb 
+ DietPi-Software | O!MPD: Set "server.stream-response-body = 1" with Lighttpd to resolve database update loop
@MichaIng MichaIng added this to the v6.25 milestone Jun 2, 2019
@MichaIng MichaIng self-assigned this Jun 2, 2019
MichaIng added 7 commits June 3, 2019 00:54
@MichaIng
v6.25
cf36e5a 
+ DietPi-Software | O!MPD: Install current version from master branch, which fixes a bug with Buster Lighttpd on "Now Playing" page as well. After next official release, revert to latest release from: https://api.github.com/repos/ArturSierzant/OMPD/releases/latest
+ DietPi-Software | O!MPD: Apply Lighttpd drop-in config to solve database update loop: #2156
+ DietPi-Software | Use userdata subdir variables, as we already have them
@MichaIng
v6.25
0b628ef 
+ DietPi-Software | O!MPD: Install dependencies for YouTube and Tidal support. Python is installed with MPD anyway so it is minimal overhead for users that do not require it.
@MichaIng
v6.25
ce0f9f2 
+ DietPi-Software | O!MPD: Backup old config file on reinstalls
@MichaIng
v6.25
ab5adf4 
+ DietPi-Patch | O!MPD: Reinstall to apply current master version and YouTube + Tidal support
@MichaIng
v6.25
39dfeac 
+ DietPi-Patch | Remove old O!MPD reinstalls and database update hint
@MichaIng
v6.25
69f57c6 
+ DietPi-Software | O!MPD: Add info that database update is required after reinstall
@MichaIng
v6.25
2d11673 
+ CHANGELOG | O!MPD: Current upstream version will be installed now and existing instances will be upgraded during DietPi-Update, which requires a config file reset. A backup to recover custom settings from will be created. YouTube and Tidal support is added now by default.
This was referenced Jun 3, 2019
Closed
Closed
@MichaIng MichaIng mentioned this pull request Jun 4, 2019
Closed
MichaIng added 8 commits June 4, 2019 17:12
@MichaIng
v6.25
9e1c4aa 
+ DietPi-Software | O!MPD: Preserve old config file and database completely, old database will be migrated automatically
+ DietPi-Software | O!MPD: Use local override config instead of touching the default config file.
+ DietPi-Software | O!MPD: Do not manually create and import the database, as this is done automatically, if database user exists
+ DietPi-Software | O!MPD: Switch to mysqld socket connection which is generally to be preferred when database server and webserver/PHP are on the same machine
@MichaIng
v6.25
87b1b46 
+ DietPi-Patch | O!MPD: Create local override config, if non-existent, to trigger preserving settings on reinstall
@MichaIng
v6.25
1f38e29 
+ CHANGELOG | Config and database is now fully preserved
@MichaIng
v6.25
aa244e8 
+ DietPi-Software | O!MPD: Remove Lighttpd drop-in config on uninstall
@MichaIng
v6.25
f6f4f2f 
+ DietPi-Software | O!MPD: Syntax: "mv" allows wildcard in target path but not with target file name given
@MichaIng
v6.25
1f4300e 
+ DietPi-Update | Safe new Git owner+branch to file BEFORE running incremental patches to assure that all GitHub downloads are done/attempted from matching branch, e.g. during software reinstalls
+ DietPi-Update | Minor coding
@MichaIng
v6.25
1c83b5a 
+ DietPi-Set_software | Verify_DietPi_Txt(): Current $G_GITBRANCH/$G_GITOWNER can be used, since DietPi-Update now saves these values before calling this script.
+ DietPi-Set_software | Minor coding
@MichaIng
v6.25
894331b 
+ DietPi-Patch | Pre-v6.25: Save target Git branch/owner to file now to prevent downloads from non-matching branch, e.g. during software reinstalls
@MichaIng MichaIng merged commit 5bb01c0 into dev Jun 4, 2019
@MichaIng MichaIng deleted the ompd branch June 4, 2019 17:52
@MichaIng MichaIng mentioned this pull request Jun 24, 2019
Merged
@MichaIng MichaIng mentioned this pull request Jul 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MichaIng MichaIng

Labels
Bug 🐞 Enhancement 💨
Projects
None yet
Milestone
v6.25
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaIng