Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require f-strings when the formatee is a bytestring #25

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Don't require f-strings when the formatee is a bytestring #25

merged 2 commits into from
Jul 27, 2022

Conversation

akx
Copy link
Contributor

@akx akx commented Jul 27, 2022

Fixes #22

@MichaelKim0407
Copy link
Owner

Thanks, looks good apart from the minor suggestion

@akx akx requested a review from MichaelKim0407 July 27, 2022 13:04
@MichaelKim0407 MichaelKim0407 merged commit c10c92e into MichaelKim0407:develop Jul 27, 2022
@MichaelKim0407
Copy link
Owner

Changes have been released. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKim0407 MichaelKim0407 Awaiting requested review from MichaelKim0407

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should not trigger on byte strings
2 participants
@akx @MichaelKim0407