-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified the HTML structure by removing an extra wrapping `<div>` around the `<p-tabs>` component. This cleanup reduces unnecessary nesting and improves code readability without affecting functionality.
Lowered `min-response-size` for HTTP compression to 1024 bytes across all services, improving compression efficiency for smaller responses. Refactored SitemapXmlService to utilize virtual threads and asynchronous processing, enhancing scalability and maintainability. Enhanced SitemapXmlController with better error handling for missing 'Host' headers.
Moved `spring-boot-devtools` to a new 'dev' profile across all services. This enables easier activation of development-specific dependencies by setting `spring.profiles.active=dev`. Removed `spring-boot-devtools` from the default dependency list to streamline production builds.
Upgraded the Spring Boot parent version from 3.4.1 to 3.4.2 in the pom.xml. This ensures the project benefits from the latest fixes and improvements included in the new version.
Replaced Spring Cloud Gateway with Spring MVC and adjusted configurations and dependencies accordingly (e.g., switching to `spring-cloud-starter-gateway-mvc`). Removed outdated authentication filter-related components and improved modularity by restructuring Feign Clients and adding CORS configuration for dev profiles. Updated application properties and cleaned up unnecessary logging and dependencies.
Uncommented the admin-service route in the gateway configuration. This activates routing to the admin-service using the specified host predicate.
Replaced YAML-based route configurations with Kotlin functional routes for better maintainability and flexibility. Updated controllers to use `HandlerFunction` instead of annotations, aligning with the functional approach. Adjusted dependencies to support new routing setup.
Ensure the virtual thread executor is properly closed using a `@PreDestroy` annotated method. This prevents potential resource leaks by guaranteeing cleanup when the service is destroyed.
Change Reactive to Servlet Gateway
Replaced conditional fetching logic with a strategy pattern by introducing the `DataLocationFetcher` interface and specific implementations (`ChessEventsFetcher` and `ChessOpeningsFetcher`). Updated `DataLocationsFetcher` to dynamically delegate fetching to appropriate fetcher, improving extensibility and reducing coupling.
Refactor data fetching with strategy pattern implementation
Introduced a `defaultHolder` in the Meta service and added methods for setting metadata efficiently. Updated "About Me" section structure, translations, and metadata to better reflect content and improve SEO. Ensured metadata reverts on component destruction.
Eliminated unnecessary outer `<div class="container mx-auto">` wrappers across multiple chess settings components. Simplifies the HTML structure and removes extra nesting to improve readability and maintainability.
Update about me page
Introduced a user-configurable tree depth setting in the chess-opening component using a number input tied to the Angular ngModel. Updated related services and templates to support dynamic tree depth adjustments, with localization strings added for both English and German.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
admin-service
authentication-service
chess-service
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
fitness-service
gateway-service
music-service
registry-service
usermanagement-service
website
website-service
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.