Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 remove jupyter commands #1034

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Conversation

yzhang-gh
Copy link

Fix #897.

@codecov
Copy link

codecov bot commented Mar 11, 2018

Codecov Report

Merging #1034 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
- Coverage   64.07%   64.04%   -0.03%     
==========================================
  Files         260      260              
  Lines       12013    12010       -3     
  Branches     2134     2133       -1     
==========================================
- Hits         7697     7692       -5     
- Misses       4307     4309       +2     
  Partials        9        9
Impacted Files Coverage Δ
src/client/common/featureDeprecationManager.ts 47.05% <ø> (-6.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74fb50...fcee201. Read the comment docs.

@DonJayamanne DonJayamanne self-requested a review March 12, 2018 16:17
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neilsustc

  • Remove the jupyter commands from the localization files as well (package.nls.*.json).
  • Remove jupyterDecrationInfo from src/client/common/featureDeprecationManager.ts

@yzhang-gh
Copy link
Author

Done. And it seems that featureDeprecationManager is useless now. Would you like to keep it?

@DonJayamanne
Copy link

@neilsustc
No it isn't, if you look at the code, its checking for the usage of python.formatting.formatOnSave.

@DonJayamanne DonJayamanne merged commit dc78b31 into microsoft:master Mar 12, 2018
@brettcannon
Copy link
Member

@DonJayamanne can you add a news entry for this change?

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting commands in vscode-python & vscodeJupyter
3 participants