Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting commands in vscode-python & vscodeJupyter #897

Closed
osya opened this issue Feb 25, 2018 · 2 comments · Fixed by #1034
Closed

Conflicting commands in vscode-python & vscodeJupyter #897

osya opened this issue Feb 25, 2018 · 2 comments · Fixed by #1034
Assignees
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Milestone

Comments

@osya
Copy link

osya commented Feb 25, 2018

Environment data

VS Code version: 1.20.1
Python Extension version: 2018.1.0
Python Version: 3.6.4
OS and version: Windows 10 x64 Pro

Actual behavior

Conflicting commands which exists in both vscode-python & vscodeJupyter extensions: runSelectionLine, execCurrentCell, execCurrentCellAndAdvance, gotToPreviousCell, gotToNextCell

Expected behavior

Expected nothing conflicted commands in these two extensions

Steps to reproduce:

Install extensions vscode-python & vscodeJupyter, open Developer Tools Console and see messages there

Logs

Output from Console window (Help->Developer Tools menu)

extensionService.ts:791 [C:\Users\info_000\.vscode\extensions\ms-python.python-2018.1.0]: Command `jupyter.runSelectionLine` appears multiple times in the `commands` section.
extensionService.ts:791 [C:\Users\info_000\.vscode\extensions\ms-python.python-2018.1.0]: Command `jupyter.execCurrentCell` appears multiple times in the `commands` section.
extensionService.ts:791 [C:\Users\info_000\.vscode\extensions\ms-python.python-2018.1.0]: Command `jupyter.execCurrentCellAndAdvance` appears multiple times in the `commands` section.
extensionService.ts:791 [C:\Users\info_000\.vscode\extensions\ms-python.python-2018.1.0]: Command `jupyter.gotToPreviousCell` appears multiple times in the `commands` section.
extensionService.ts:791 [C:\Users\info_000\.vscode\extensions\ms-python.python-2018.1.0]: Command `jupyter.gotToNextCell` appears multiple times in the `commands` section.

I also tried to register issue there Conflicting commands in vscode-python & vscodeJupyter

@osya
Copy link
Author

osya commented Feb 25, 2018 via email

@DonJayamanne
Copy link

Lol, deleted that comment as soon I realized this wasn't a PR, for some reason I assumed this was a PR.

@DonJayamanne DonJayamanne added good first issue needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Feb 26, 2018
@DonJayamanne DonJayamanne added this to the March 2018 milestone Feb 26, 2018
DonJayamanne pushed a commit that referenced this issue Mar 12, 2018
* remove jupyter commands
* Fix #897
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants