-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide new interactive window experience for editing notebooks directly #3335
Comments
Start of this is here: |
Will this feature make python interactive window more jupyter-alike? |
Sort of. It will change the way you edit cells at least. They'll be inline like a jupyter notebook. |
How soon will this update be released? It won't be long, right? |
Likely not a first. Not sure how the VIM extension changes editing, so we'd have to look into it. Extensions that modify the editor would have to be reapplied to this window.
Yep. That's the idea. Or go between them if you like. |
Sorry are you suggesting people should use pycharm, or that we should have a pycharm like experience? |
Nope, I didn't suggest PyCharm. I don't use PyCharm actually. I mean PyCharm's jupyter style is another solution for VS Code's python interactive window. Sorry for the comment above, I didn't realise it will cause misundstanding. |
That's what I was hoping you meant :). This is also in our plans but will likely happen after the idea I showed here. |
Keep the current python interactive window on .py file but make the display of output like the PyCharm Jupyter or Atom Hydrogen where input each cell has its corresponded output cell. Is that right? |
Yes the idea is to have 3 ways to do jupyter like work
|
Going on vacation. Work is here: Here's the minimum list of stuff left to do:
|
Maybe also investigate https://github.com/microsoft/azuredatastudio to see how they handle the monaco editor |
Will jupyter extension be compatible with this new interactive window? It seems to be a jupyter notebook inside VSCode? And debug Cell? |
Is this implemented with a WebView? |
@AeneasZhu. This new notebook editing experience is basically another way of interacting with the Interactive Window experience. In the interactive window your .py file is being used as a base for the source code and the interactive window is just to display a history of what you have executed. This new editing experience uses the same output elements as the interactive windows, but instead of entering code from a .py file it uses a more jupyter like interface where the code elements are all inline with their output. It shares much of its code with the existing interactive window, so yes it is also implemented as a WebView and will not initially support VS extensions like VSCodeVim (sadly for me as I use that as well). |
Creating work list from Rich's last comment
|
@IanMatthewHuff Will this feature be added in Sep update? |
This is an unbelievably strong addition which I feel should be very actively promoted on the blog or in some sort of announcement. The current state of Jupyter support is acceptable, but the flexibility proposed and implemented by @rchiodo just elevates VSCODE as a whole to another level for working data scientists. I do a lot of my development in Jupyter in the browser but I switch to VSCODE for production code or for FOSS contributions. Being able to shift my entire workflow away from the browser while retaining the same sort of user interface (especially regarding fonts, compare microsoft/vscode-python#5256) is fantastic! |
Echoing comments above, I'm really excited for this feature to come to the Python VS Code extension! My machine learning class (and several other linear algebra/ML classes at my college) actually requires us to use Jupyter Notebooks (converted to PDF) for homework submissions. The homeworks involve submitting notebooks with code, plots, and significant amounts of markdown with LaTeX equations (markdown/LaTeX is about 70% of the notebook), so I've defaulted to the browser workflow in the interest of directly editing and re-executing markdown cells in place. But I'd love to have the direct editing experience in VS Code—I miss the IntelliSense, Git integration for versioning/collaborating on my notebooks, and not being browser-bound. Can't wait for this to ship!! |
@AeneasZhu Intellisense is being tracked by a bug:#7316, although if you have more specific feedback, that would great. It should be partially working. Debugging cells is something we're going to release later. It's on our todo list. VIM support is longer term. We probably need support from VS code to support loading extensions into the editor we're hosting. However, intellicode should be working. What results did you get when you tried it? |
https://user-images.githubusercontent.com/44701446/65811893-13adc000-e1f2-11e9-8b94-0e626455f03d.gif Is this style of 'Interactive window where cells don't append unless you run a new cell' still on the todo list? |
Yes. This issue here is tracking it: Feel free to upvote it. |
@rchiodo omg, I just tried the new ipynb editor out, it's UNBELIEVABLE! Many congrats to all involved! |
@rchiodo the customized color theme like italic seems no longer work and also no autocompletion for |
Sorry @StevenLi-DS but not sure what you mean by customized color theme not working. Can you enter new issues for each thing you're seeing? Theme support and intellisense support should be identical to before the notebook editor was created. If you're seeing a regression please log an issue. |
Is there a way to enable nbextensions? |
No sorry nbextensions are not currently supported. Please enter an issue, if you'd like them to be, so other people can up vote the issue. |
table of contents feature for notebooks would be great |
@zouhx11, please feel free to enter a suggestion for a table of contents. This way others can up vote it. |
When opening an ipynb file it goes right away to the interactive mode. Is there a way to look at the raw json file as well? Sometimes you want to look at the metadata for example. |
what's even more problematic, I can't compare changes in notebooks, I also goes into the interactive mode. |
The compare changes in notebooks is a bug: To look at the actual JSON, you have to turn this setting off: With the setting turned off, ipynb files don't automatically open in the new editor. You can still open them though with a right click menu. |
Hello, i found about this functionality today - and it is great! It is making me consider switching my current IDE. I have few minor GUI related issues however, which I haven't seen mentioned around here:
Still, I am very thankful for this functionality and look forward to subsequent releases. OS: Windows 10 |
@rchiodo Hi, how can we remove the horizontal frames with "run and markdown button" in the latest version, as described in this question? It takes up a lot of space but is useless most of the time. I just want an interface like the one in your GIF (native jupyter-like experience). |
That GIF is one of our early versions. We didn't ship it that way. There is no way to turn off the toolbar. However there is another way to open notebooks that we're working on. See this here: |
Reusing the interactive window, when opening an ipynb file, just load it into an interactive window, but with these differences:
The text was updated successfully, but these errors were encountered: