-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest should show exact match first (case insensitive) #21362
Comments
I have tons of issues that ask for improving this for quick open and IntelliSense is also similar but currently uses its own custom solution. Maybe about time to convert to one solution... Unfortunately there are different contexts with different ideal sorting/scoring (files vs commands vs methods) and on top of that there is everyones own custom opinion what should come first. |
Today IntelliSense scores like this
So what you see is expected because line sensitive matches count the most. Before making further changes we need a sound model describing what factors (match index, match count, camel-case match, contiguous match, case-sensitivity etc) count how. |
I don't have enough knowledge about all the issues around IntelliSense so I can't help much with the sound model, but I'd argue case-insensitive match at the beginning should score higher than case-sensitive match in the middle. Also, Vim's smartcase (http://vim.wikia.com/wiki/Searching) is really useful. Maybe VSCode can also do scoring case-sensitively if completion input has any uppercase char, and case-insensitively if input has no uppercase char? |
closing this as dupe of #22153 |
I'm not sure how this is a dupe of #22153. The other issue discusses fuzzy matching, where this one discusses exact match case insensitivity and case-insensitive starting characters matching. I would expect the same behavior for the case-insensitive example given for As mentioned above it is more complicated than that, but at the same time this is what feels completely intuitive to me, so I am hoping something can be done about it. Obviously people are used to how vscode is scoring matches now, so it may be best, assuming this is implemented, to make it an option. |
@jrieken I'm unlocking this in light of #43464: I don't think #22153 covers this. When I type out a word if there is a suggestion that's an exact match, it should have the highest score. Can we reopen this, or are you interested in opening a mega issue that covers all scoring issue as @bpasero suggested?
|
Please file a separate issue, this issue has nothing to do with the current implementation anymore... |
This feels really weird. If one starts by typing "line" he would expect methods starting with line instead of spline.
There is also an exact match (case insensitive):
The text was updated successfully, but these errors were encountered: