-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add intenseTextStyle to the docs #381
Conversation
Docs Build status updates of commit 914bfb8:
|
File | Status | Preview URL | Details |
---|---|---|---|
TerminalDocs/new-terminal-arguments.md | View | Details | |
TerminalDocs/customize-settings/profile-appearance.md | ✅Succeeded | View |
TerminalDocs/new-terminal-arguments.md
- Line 0, Column 0: [Warning-h1-missing]
H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
…10759) ## Summary of the Pull Request This adds a new setting `intenseTextStyle`. It's a per-appearance, control setting, defaulting to `"all"`. * When set to `"all"` or `["bold", "bright"]`, then we'll render text as both **bold** and bright (1.10 behavior) * When set to `"bold"`, `["bold"]`, we'll render text formatted with `^[[1m` as **bold**, but not bright * When set to `"bright"`, `["bright"]`, we'll render text formatted with `^[[1m` as bright, but not bold. This is the pre 1.10 behavior * When set to `"none"`, we won't do anything special for it at all. ## references * I last did this in #10648. This time it's an enum, so we can add bright in the future. It's got positive wording this time. * ~We will want to add `"bright"` as a value in the future, to disable the auto intense->bright conversion.~ I just did that now. * #5682 is related ## PR Checklist * [x] Closes #10576 * [x] I seriously don't think we have an issue for "disable intense is bright", but I'm not crazy, people wanted that, right? #2916 (comment) was the closest * [x] I work here * [x] Tests added/passed * [x] MicrosoftDocs/terminal#381 ## Validation Steps Performed <!--  -->  Yea that works. Printed some bold text, toggled it on, the text was no longer bold. hooray. ### EDIT, 10 Aug ```json "intenseTextStyle": "none", "intenseTextStyle": "bold", "intenseTextStyle": "bright", "intenseTextStyle": "all", "intenseTextStyle": ["bold", "bright"], ``` all work now. Repro script: ```sh printf "\e[1m[bold]\e[m[normal]\e[34m[blue]\e[1m[bold blue]\e[m\n" ```
…10759) This adds a new setting `intenseTextStyle`. It's a per-appearance, control setting, defaulting to `"all"`. * When set to `"all"` or `["bold", "bright"]`, then we'll render text as both **bold** and bright (1.10 behavior) * When set to `"bold"`, `["bold"]`, we'll render text formatted with `^[[1m` as **bold**, but not bright * When set to `"bright"`, `["bright"]`, we'll render text formatted with `^[[1m` as bright, but not bold. This is the pre 1.10 behavior * When set to `"none"`, we won't do anything special for it at all. * I last did this in #10648. This time it's an enum, so we can add bright in the future. It's got positive wording this time. * ~We will want to add `"bright"` as a value in the future, to disable the auto intense->bright conversion.~ I just did that now. * #5682 is related * [x] Closes #10576 * [x] I seriously don't think we have an issue for "disable intense is bright", but I'm not crazy, people wanted that, right? #2916 (comment) was the closest * [x] I work here * [x] Tests added/passed * [x] MicrosoftDocs/terminal#381 <!--  -->  Yea that works. Printed some bold text, toggled it on, the text was no longer bold. hooray. ```json "intenseTextStyle": "none", "intenseTextStyle": "bold", "intenseTextStyle": "bright", "intenseTextStyle": "all", "intenseTextStyle": ["bold", "bright"], ``` all work now. Repro script: ```sh printf "\e[1m[bold]\e[m[normal]\e[34m[blue]\e[1m[bold blue]\e[m\n" ```
* Update to change equal symbol to plus key Addresses issue #196 *On my Surface Book keyboard + and = are the same key, but this may not be the case for all keyboard layouts. * change + to plus as shipped by default * Add notes about title change persistance * Update settings.json section * Link settings.json mentions * Fix links * fix a few more links * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <[email protected]> * Update TerminalDocs/dynamic-profiles.md Co-authored-by: Kayla Cinnamon <[email protected]> * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <[email protected]> * Remove repititious section * Added browser media keys (#371) * Add link to what is command line shell video (#377) * add intenseTextStyle to the docs (#381) * Multiple new pane features (#383) Documentation for - microsoft/terminal#10713 - microsoft/terminal#10638 - microsoft/terminal#10780 - microsoft/terminal#10927 * wt.exe --window argument now available (#388) * Add notes that the `font` object is only 1.10+ (#389) Co-authored-by: Kayla Cinnamon <[email protected]> * Remove MinimizeToTray action mentions (#387) * Docs updates for 1.11 release (#397) * Specify OS version availability for defterm (#417) Co-authored-by: Kayla Cinnamon <[email protected]> * Remove tilde Reshttps://github.com/MicrosoftDocs/terminal/issues/260olves * Improve dup tab description #292 * Update minimizetotray setting to new name * Merge release 1.12 into master (#428) Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Pankaj Bhojwani <[email protected]> Co-authored-by: Matt Wojciakowski <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Carlos Zamora <[email protected]> Co-authored-by: Schuyler Rosefield <[email protected]> Co-authored-by: PankajBhojwani <[email protected]> * Remove preview labels * Add redirect for old powerline page * Add vscode to gitignore * Config changes to reflect the default branch from master to main. * Add a note about the command palette to this doc (#447) * Add details about the command used to print the table (#446) * initialPos -> initialPosition (#445) * Add tip on extensions for configuration files (#440) * Add tip on extensions for configuration files Resolves #423 * fix numbering Co-authored-by: Matt Wojciakowski <[email protected]> * Corrected path (#434) The LocalAppData path was missing `{app-name}` * Update panes.md (#432) Minor edit on a shortcut key * Correct $PROFILE configuration (#431) When using winget, Oh-my-posh will not add Set-PoshPrompt to path, the execution will fail. The correct configuration can be found in https://ohmyposh.dev/docs/windows#replace-your-existing-prompt * Add a sample page (#444) * Add FAQ page (#442) * Add FAQ page * Finalize faq v1 * Replace md with yml, add toc * Update with settings UI feedback from kayla * fix image link * Fix preview faq Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Floris Westerman <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Schuyler Rosefield <[email protected]> Co-authored-by: Sean Jacobs <[email protected]> Co-authored-by: Leon Liang <[email protected]> Co-authored-by: Carlos Zamora <[email protected]> Co-authored-by: Pankaj Bhojwani <[email protected]> Co-authored-by: PankajBhojwani <[email protected]> Co-authored-by: Nivaldo Tokuda <[email protected]> Co-authored-by: David A. Sjøen <[email protected]> Co-authored-by: tharindu sathischandra <[email protected]> Co-authored-by: Cutano <[email protected]>
* Update to change equal symbol to plus key Addresses issue #196 *On my Surface Book keyboard + and = are the same key, but this may not be the case for all keyboard layouts. * change + to plus as shipped by default * Add notes about title change persistance * Update settings.json section * Link settings.json mentions * Fix links * fix a few more links * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <[email protected]> * Update TerminalDocs/dynamic-profiles.md Co-authored-by: Kayla Cinnamon <[email protected]> * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <[email protected]> * Remove repititious section * Added browser media keys (#371) * Add link to what is command line shell video (#377) * add intenseTextStyle to the docs (#381) * Multiple new pane features (#383) Documentation for - microsoft/terminal#10713 - microsoft/terminal#10638 - microsoft/terminal#10780 - microsoft/terminal#10927 * wt.exe --window argument now available (#388) * Add notes that the `font` object is only 1.10+ (#389) Co-authored-by: Kayla Cinnamon <[email protected]> * Remove MinimizeToTray action mentions (#387) * Docs updates for 1.11 release (#397) * Specify OS version availability for defterm (#417) Co-authored-by: Kayla Cinnamon <[email protected]> * Remove tilde Reshttps://github.com/MicrosoftDocs/terminal/issues/260olves * Improve dup tab description #292 * Update minimizetotray setting to new name * Merge release 1.12 into master (#428) Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Pankaj Bhojwani <[email protected]> Co-authored-by: Matt Wojciakowski <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Carlos Zamora <[email protected]> Co-authored-by: Schuyler Rosefield <[email protected]> Co-authored-by: PankajBhojwani <[email protected]> * Remove preview labels * Add redirect for old powerline page * Add vscode to gitignore * Config changes to reflect the default branch from master to main. * Add a note about the command palette to this doc (#447) * Add details about the command used to print the table (#446) * initialPos -> initialPosition (#445) * Add tip on extensions for configuration files (#440) * Add tip on extensions for configuration files Resolves #423 * fix numbering Co-authored-by: Matt Wojciakowski <[email protected]> * Corrected path (#434) The LocalAppData path was missing `{app-name}` * Update panes.md (#432) Minor edit on a shortcut key * Correct $PROFILE configuration (#431) When using winget, Oh-my-posh will not add Set-PoshPrompt to path, the execution will fail. The correct configuration can be found in https://ohmyposh.dev/docs/windows#replace-your-existing-prompt * Add a sample page (#444) * Add FAQ page (#442) * Add FAQ page * Finalize faq v1 * Replace md with yml, add toc * Update with settings UI feedback from kayla * fix image link * Fix preview faq * Add a guide for using OSC9;9 (#449) * I think this is everything we need. Pushing because I don't know if the image paths are right * This should fix the warnings * maybe fix the urls? * typos * Update TerminalDocs/tutorials/new-tab-same-directory.md Co-authored-by: Felix Christl <[email protected]> Co-authored-by: Matt Wojciakowski <[email protected]> Co-authored-by: Felix Christl <[email protected]> * Minor quake mode text update (#454) * DocuTune: Fix ms.topic values (#453) Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Floris Westerman <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Schuyler Rosefield <[email protected]> Co-authored-by: Sean Jacobs <[email protected]> Co-authored-by: Leon Liang <[email protected]> Co-authored-by: Carlos Zamora <[email protected]> Co-authored-by: Pankaj Bhojwani <[email protected]> Co-authored-by: PankajBhojwani <[email protected]> Co-authored-by: Nivaldo Tokuda <[email protected]> Co-authored-by: David A. Sjøen <[email protected]> Co-authored-by: tharindu sathischandra <[email protected]> Co-authored-by: Cutano <[email protected]> Co-authored-by: Felix Christl <[email protected]> Co-authored-by: Alex Buck <[email protected]>
* Add powerline redirect (#439) * Add redirect for old powerline page * Add vscode to gitignore * Main > Live (#448) * Update to change equal symbol to plus key Addresses issue #196 *On my Surface Book keyboard + and = are the same key, but this may not be the case for all keyboard layouts. * change + to plus as shipped by default * Add notes about title change persistance * Update settings.json section * Link settings.json mentions * Fix links * fix a few more links * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <[email protected]> * Update TerminalDocs/dynamic-profiles.md Co-authored-by: Kayla Cinnamon <[email protected]> * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <[email protected]> * Remove repititious section * Added browser media keys (#371) * Add link to what is command line shell video (#377) * add intenseTextStyle to the docs (#381) * Multiple new pane features (#383) Documentation for - microsoft/terminal#10713 - microsoft/terminal#10638 - microsoft/terminal#10780 - microsoft/terminal#10927 * wt.exe --window argument now available (#388) * Add notes that the `font` object is only 1.10+ (#389) Co-authored-by: Kayla Cinnamon <[email protected]> * Remove MinimizeToTray action mentions (#387) * Docs updates for 1.11 release (#397) * Specify OS version availability for defterm (#417) Co-authored-by: Kayla Cinnamon <[email protected]> * Remove tilde Reshttps://github.com/MicrosoftDocs/terminal/issues/260olves * Improve dup tab description #292 * Update minimizetotray setting to new name * Merge release 1.12 into master (#428) Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Pankaj Bhojwani <[email protected]> Co-authored-by: Matt Wojciakowski <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Carlos Zamora <[email protected]> Co-authored-by: Schuyler Rosefield <[email protected]> Co-authored-by: PankajBhojwani <[email protected]> * Remove preview labels * Add redirect for old powerline page * Add vscode to gitignore * Config changes to reflect the default branch from master to main. * Add a note about the command palette to this doc (#447) * Add details about the command used to print the table (#446) * initialPos -> initialPosition (#445) * Add tip on extensions for configuration files (#440) * Add tip on extensions for configuration files Resolves #423 * fix numbering Co-authored-by: Matt Wojciakowski <[email protected]> * Corrected path (#434) The LocalAppData path was missing `{app-name}` * Update panes.md (#432) Minor edit on a shortcut key * Correct $PROFILE configuration (#431) When using winget, Oh-my-posh will not add Set-PoshPrompt to path, the execution will fail. The correct configuration can be found in https://ohmyposh.dev/docs/windows#replace-your-existing-prompt * Add a sample page (#444) * Add FAQ page (#442) * Add FAQ page * Finalize faq v1 * Replace md with yml, add toc * Update with settings UI feedback from kayla * fix image link * Fix preview faq Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Floris Westerman <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Schuyler Rosefield <[email protected]> Co-authored-by: Sean Jacobs <[email protected]> Co-authored-by: Leon Liang <[email protected]> Co-authored-by: Carlos Zamora <[email protected]> Co-authored-by: Pankaj Bhojwani <[email protected]> Co-authored-by: PankajBhojwani <[email protected]> Co-authored-by: Nivaldo Tokuda <[email protected]> Co-authored-by: David A. Sjøen <[email protected]> Co-authored-by: tharindu sathischandra <[email protected]> Co-authored-by: Cutano <[email protected]> * Toc update (#457) * Update to change equal symbol to plus key Addresses issue #196 *On my Surface Book keyboard + and = are the same key, but this may not be the case for all keyboard layouts. * change + to plus as shipped by default * Add notes about title change persistance * Update settings.json section * Link settings.json mentions * Fix links * fix a few more links * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <[email protected]> * Update TerminalDocs/dynamic-profiles.md Co-authored-by: Kayla Cinnamon <[email protected]> * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <[email protected]> * Remove repititious section * Added browser media keys (#371) * Add link to what is command line shell video (#377) * add intenseTextStyle to the docs (#381) * Multiple new pane features (#383) Documentation for - microsoft/terminal#10713 - microsoft/terminal#10638 - microsoft/terminal#10780 - microsoft/terminal#10927 * wt.exe --window argument now available (#388) * Add notes that the `font` object is only 1.10+ (#389) Co-authored-by: Kayla Cinnamon <[email protected]> * Remove MinimizeToTray action mentions (#387) * Docs updates for 1.11 release (#397) * Specify OS version availability for defterm (#417) Co-authored-by: Kayla Cinnamon <[email protected]> * Remove tilde Reshttps://github.com/MicrosoftDocs/terminal/issues/260olves * Improve dup tab description #292 * Update minimizetotray setting to new name * Merge release 1.12 into master (#428) Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Pankaj Bhojwani <[email protected]> Co-authored-by: Matt Wojciakowski <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Carlos Zamora <[email protected]> Co-authored-by: Schuyler Rosefield <[email protected]> Co-authored-by: PankajBhojwani <[email protected]> * Remove preview labels * Add redirect for old powerline page * Add vscode to gitignore * Config changes to reflect the default branch from master to main. * Add a note about the command palette to this doc (#447) * Add details about the command used to print the table (#446) * initialPos -> initialPosition (#445) * Add tip on extensions for configuration files (#440) * Add tip on extensions for configuration files Resolves #423 * fix numbering Co-authored-by: Matt Wojciakowski <[email protected]> * Corrected path (#434) The LocalAppData path was missing `{app-name}` * Update panes.md (#432) Minor edit on a shortcut key * Correct $PROFILE configuration (#431) When using winget, Oh-my-posh will not add Set-PoshPrompt to path, the execution will fail. The correct configuration can be found in https://ohmyposh.dev/docs/windows#replace-your-existing-prompt * Add a sample page (#444) * Add FAQ page (#442) * Add FAQ page * Finalize faq v1 * Replace md with yml, add toc * Update with settings UI feedback from kayla * fix image link * Fix preview faq * Add a guide for using OSC9;9 (#449) * I think this is everything we need. Pushing because I don't know if the image paths are right * This should fix the warnings * maybe fix the urls? * typos * Update TerminalDocs/tutorials/new-tab-same-directory.md Co-authored-by: Felix Christl <[email protected]> Co-authored-by: Matt Wojciakowski <[email protected]> Co-authored-by: Felix Christl <[email protected]> * Minor quake mode text update (#454) * DocuTune: Fix ms.topic values (#453) Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Floris Westerman <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Schuyler Rosefield <[email protected]> Co-authored-by: Sean Jacobs <[email protected]> Co-authored-by: Leon Liang <[email protected]> Co-authored-by: Carlos Zamora <[email protected]> Co-authored-by: Pankaj Bhojwani <[email protected]> Co-authored-by: PankajBhojwani <[email protected]> Co-authored-by: Nivaldo Tokuda <[email protected]> Co-authored-by: David A. Sjøen <[email protected]> Co-authored-by: tharindu sathischandra <[email protected]> Co-authored-by: Cutano <[email protected]> Co-authored-by: Felix Christl <[email protected]> Co-authored-by: Alex Buck <[email protected]> Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Floris Westerman <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Schuyler Rosefield <[email protected]> Co-authored-by: Sean Jacobs <[email protected]> Co-authored-by: Leon Liang <[email protected]> Co-authored-by: Carlos Zamora <[email protected]> Co-authored-by: Pankaj Bhojwani <[email protected]> Co-authored-by: PankajBhojwani <[email protected]> Co-authored-by: Nivaldo Tokuda <[email protected]> Co-authored-by: David A. Sjøen <[email protected]> Co-authored-by: tharindu sathischandra <[email protected]> Co-authored-by: Cutano <[email protected]> Co-authored-by: Felix Christl <[email protected]> Co-authored-by: Alex Buck <[email protected]>
See microsoft/terminal#10759