-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PowerShell to install in Sandbox #4264
Conversation
The current script does not work, there is a typo and missing dependency as well as being an older version. I have fixed these, tested with Windows 10 and 11 but tried to keep the script simple and like the original.
@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit a9801ce: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
PRMerger Results
|
@KevinLaMS appreciate you are probably busy, but please could you let me know if there is a process I should follow to get this reviewed, or if I have missed something. Thanks |
@glawrence, thank you for this. I came up with a different solution using the Microsoft Store URI for Microsoft.UI.Xaml.2.7, but found the The only thing I would change is to either make the dot-sourcing of the files consistent, which would keep it simpler, or, since these commands may be put into a script residing on a read-only mapped folder inside the Windows Sandbox, put the downloaded files into the user temporary folder. This would change the commands to: $ProgressPreference='SilentlyContinue'
Invoke-WebRequest -Uri https://github.com/microsoft/winget-cli/releases/download/v1.4.10173/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle -OutFile "$($Env:TEMP)\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle"
Invoke-WebRequest -Uri https://aka.ms/Microsoft.VCLibs.x64.14.00.Desktop.appx -OutFile "$($Env:TEMP)\Microsoft.VCLibs.x64.14.00.Desktop.appx"
Invoke-WebRequest -Uri https://www.nuget.org/api/v2/package/Microsoft.UI.Xaml/2.7.3 -OutFile "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3.zip"
Expand-Archive -Path "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3.zip" -DestinationPath "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3" -Force
Add-AppxPackage "$($Env:TEMP)\Microsoft.VCLibs.x64.14.00.Desktop.appx"
Add-AppxPackage "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3\tools\AppX\x64\Release\Microsoft.UI.Xaml.2.7.appx"
Add-AppxPackage "$($Env:TEMP)\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle" I also found that I could install the latest version of winget automatically by changing the URI for it to 'https://github.com/microsoft/winget-cli/releases/latest/download/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle', but any future changes in dependencies in newer versions would require the article to be updated again. |
Thanks @VShrubowich I will take that onboard but do some testing first, so I am certain the script works |
Thank you for this contribution @glawrence. Apologies for the delay. This issue was fixed in ca90ce0 |
@mattwojo It looks like the commit you refer to does not address the issue of the missing dependency on Microsoft.UI.Xaml. It only fixes the missing period in the filename. I think the fix from this PR is still needed. |
Oh! Thanks @PDeets. I'll reopen. |
@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit a9801ce: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 7def64e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
PRMerger Results
|
@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 8149086:
|
File | Status | Preview URL | Details |
---|---|---|---|
Details | |||
hub/package-manager/winget/index.md | ✅Succeeded |
- Line 0, Column 0: [Warning: github-api-failed]
Call to GitHub API failed '[RATE_LIMITED] API rate limit exceeded for installation ID 29489216.'. Try closing and reopening the PR. If you get this Error again, file an issue.
- Line 0, Column 0: [Suggestion: dependency-repository-branch-not-match]
The branch(master) used to reference in the dependency repository 'https://github.com/microsoft/Xaml-Controls-Gallery' does not match. Please confirm with cross reference repo and update 'master' to 'main' in this repo config file.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
I have taken on board your suggestion @VShrubowich @mattwojo and @PDeets I believe this is all good to go, but happy to be corrected on that |
@mattwojo @PDeets @KevinLaMS - Could you review this PR? IMPORTANT: When the changes are ready for publication, add a #label:"aq-pr-triaged" |
@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Sorry @ShannonLeavitt @mattwojo @PDeets and @KevinLaMS I think this PR has a dodgy commit from me as well as a validation warning, so I have rerolled it with #4332 so I will close this, but hopefully we can now switch to my new one |
The current script does not work, there is a typo and missing dependency as well as being an older version. I have fixed these, tested with Windows 10 and 11 but tried to keep the script simple and like the original.