Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PowerShell to install in Sandbox #4264

Closed
wants to merge 3 commits into from

Conversation

glawrence
Copy link

The current script does not work, there is a typo and missing dependency as well as being an older version. I have fixed these, tested with Windows 10 and 11 but tried to keep the script simple and like the original.

The current script does not work, there is a typo and missing dependency as well as being an older version. I have fixed these, tested with Windows 10 and 11 but tried to keep the script simple and like the original.
@prmerger-automator
Copy link
Contributor

@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit a9801ce:

✅ Validation status: passed

File Status Preview URL Details
hub/package-manager/winget/index.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Index File This PR contains a change to the index file.

@glawrence
Copy link
Author

@KevinLaMS appreciate you are probably busy, but please could you let me know if there is a process I should follow to get this reviewed, or if I have missed something. Thanks

@VShrubowich
Copy link

@glawrence, thank you for this. I came up with a different solution using the Microsoft Store URI for Microsoft.UI.Xaml.2.7, but found the Invoke-WebRequest inconsistently resulted in an "Access Denied" error. Your solution works much better.

The only thing I would change is to either make the dot-sourcing of the files consistent, which would keep it simpler, or, since these commands may be put into a script residing on a read-only mapped folder inside the Windows Sandbox, put the downloaded files into the user temporary folder. This would change the commands to:

$ProgressPreference='SilentlyContinue'
Invoke-WebRequest -Uri https://github.com/microsoft/winget-cli/releases/download/v1.4.10173/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle -OutFile "$($Env:TEMP)\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle"
Invoke-WebRequest -Uri https://aka.ms/Microsoft.VCLibs.x64.14.00.Desktop.appx -OutFile "$($Env:TEMP)\Microsoft.VCLibs.x64.14.00.Desktop.appx"
Invoke-WebRequest -Uri https://www.nuget.org/api/v2/package/Microsoft.UI.Xaml/2.7.3 -OutFile "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3.zip"
Expand-Archive -Path "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3.zip" -DestinationPath "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3" -Force
Add-AppxPackage "$($Env:TEMP)\Microsoft.VCLibs.x64.14.00.Desktop.appx"
Add-AppxPackage "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3\tools\AppX\x64\Release\Microsoft.UI.Xaml.2.7.appx"
Add-AppxPackage "$($Env:TEMP)\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle"

I also found that I could install the latest version of winget automatically by changing the URI for it to 'https://github.com/microsoft/winget-cli/releases/latest/download/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle', but any future changes in dependencies in newer versions would require the article to be updated again.

@glawrence
Copy link
Author

Thanks @VShrubowich I will take that onboard but do some testing first, so I am certain the script works

@mattwojo
Copy link
Contributor

mattwojo commented Mar 1, 2023

Thank you for this contribution @glawrence. Apologies for the delay. This issue was fixed in ca90ce0

@mattwojo mattwojo closed this Mar 1, 2023
@PDeets
Copy link

PDeets commented Mar 1, 2023

@mattwojo It looks like the commit you refer to does not address the issue of the missing dependency on Microsoft.UI.Xaml. It only fixes the missing period in the filename. I think the fix from this PR is still needed.

@mattwojo
Copy link
Contributor

mattwojo commented Mar 2, 2023

Oh! Thanks @PDeets. I'll reopen.

@mattwojo mattwojo reopened this Mar 2, 2023
@prmerger-automator
Copy link
Contributor

@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit a9801ce:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit a9801ceb475df17eaf3147ff3505336855760241 in branch patch-1 of repository https://github.com/glawrence/windows-dev-docs into branch docs (commit 25aaa787c7ac5bba056c56415b8c09b62ebdb178). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 7def64e:

✅ Validation status: passed

File Status Preview URL Details
hub/package-manager/winget/index.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Index File This PR contains a change to the index file.

@prmerger-automator
Copy link
Contributor

@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 8149086:

⚠️ Validation status: warnings

File Status Preview URL Details
⚠️Warning Details
hub/package-manager/winget/index.md ✅Succeeded

  • Line 0, Column 0: [Warning: github-api-failed] Call to GitHub API failed '[RATE_LIMITED] API rate limit exceeded for installation ID 29489216.'. Try closing and reopening the PR. If you get this Error again, file an issue.
  • Line 0, Column 0: [Suggestion: dependency-repository-branch-not-match] The branch(master) used to reference in the dependency repository 'https://github.com/microsoft/Xaml-Controls-Gallery' does not match. Please confirm with cross reference repo and update 'master' to 'main' in this repo config file.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@glawrence
Copy link
Author

I have taken on board your suggestion @VShrubowich

@mattwojo and @PDeets I believe this is all good to go, but happy to be corrected on that

@ShannonLeavitt
Copy link
Contributor

@mattwojo @PDeets @KevinLaMS - Could you review this PR?

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Mar 10, 2023
@prmerger-automator
Copy link
Contributor

@glawrence : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@glawrence
Copy link
Author

Sorry @ShannonLeavitt @mattwojo @PDeets and @KevinLaMS I think this PR has a dodgy commit from me as well as a validation warning, so I have rerolled it with #4332 so I will close this, but hopefully we can now switch to my new one

@glawrence glawrence closed this Mar 10, 2023
@glawrence glawrence deleted the patch-1 branch March 10, 2023 18:13
@mattwojo mattwojo requested review from mattwojo and removed request for KevinLaMS March 10, 2023 18:54
@mattwojo mattwojo self-assigned this Mar 10, 2023
@mattwojo mattwojo removed Change sent to author aq-pr-triaged tracking label for the PR review team labels Mar 10, 2023
learn-build-service-prod bot pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants