Add "same_id_delay" to settings + Add option to ignore control cards (volume, skip, seek, etc.) #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some options to the global.conf for handling second swipe pause + control cards
add setable same_id_delay, can be changed from settings tab. add option, to ignore controls cards for the time delay
add second swipe pause add second swipe pause (control card handling)
add second swipe pause add second swipe pause (control cards handling)
add second swipe pause add second swipe pause (control cards handling)
|
Needs #1019 be merged before? |
|
No, #1019 is included |
|
Hi @princemaxwell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MiczFlor @s-martin @jo-me
solves issue #910
Pull request #1019 fixed the bug of same_id_delay, which was not working fine.
The idea to prevent cards from being scanned twice is cool, but my opinion is, that some control cards have to be ignored by this delay. Additionally it would be nice, if the delay could be set via settings tab individually.
This pull request adds both options to the settings.
First the time delay can be set, from OFF to 1-10 seconds.
Next you can decide, how control cards will be handled. If set, control cards will not be delayed.
This will work only for these control cards:
The card ids from these cards are stored in "rfid_trigger_play.conf". We get these to the global.conf and while scanning a new card it will be checked against the registered cards in global.conf.