Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix samplecfg for GPIO component #1511

Merged
merged 2 commits into from
Feb 27, 2022
Merged

Conversation

T0bi79
Copy link
Contributor

@T0bi79 T0bi79 commented Sep 9, 2021

Short version:

  • This replaces the 'misc/sampleconfigs/gpio_settings.ini.sample' (untouched since 11 months) with the current 'components/gpio_control/example_configs/gpio_settings.ini', which contains the latest syntax

  • A few example buttons were enabled by default. I changed these to disabled too. Reason: I think it's no good idea to configure concrete GPIO ports (without knowing the user's hardware setup!), just because a user activated the GPIO control component at installation.

Longer version:
Background for bullet #1 was that, after Release 2.3, a user reported an issue with a shutdown button reacting too quickly on a fresh install ( #1509 ). This was quickly resolved after identifying a missing line in the GPIO sample config.
When we updated and extended the GPIO component few months ago, we also added an syntax-auto-update for old-style configs.
Maybe this was the reason we did not also update the sample config in the misc folder. At least for the postponed shutdown button (which didn't work before 2.3 either) these auto-fixes did not suffice completely. So it's safer to bring the sample config to the latest syntax.

@s-martin
Copy link
Collaborator

Thanks for fixing this!

i think we should also add some info to the docs that a user has to activate each button.

@s-martin s-martin added the bug label Sep 11, 2021
@T0bi79
Copy link
Contributor Author

T0bi79 commented Sep 17, 2021

i think we should also add some info to the docs that a user has to activate each button.

I wrote some short additions into the Wiki entry: https://github.com/MiczFlor/RPi-Jukebox-RFID/wiki/Using-GPIO-hardware-buttons

@s-martin s-martin added this to the 2.4 milestone Oct 5, 2021
@MiczFlor MiczFlor merged commit 0c79f32 into MiczFlor:develop Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants