Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded homedir in install scritp #1543

Merged
merged 3 commits into from
Feb 27, 2022
Merged

Remove hardcoded homedir in install scritp #1543

merged 3 commits into from
Feb 27, 2022

Conversation

Groovylein
Copy link
Collaborator

Will resolve #866

Replacing /home/pi with the home folder of the current user (echo $HOME)

What I've tested and looked good so far:

  • Created docker test with alternative user hans
  • Installed with user hugo on my RPi3 (classic installation)
    • uploaded and listened to one mp3 file
  • Installed with user pi on my RPi3 (classic installation)
    • uploaded and listened to one mp3 file

Not Tested since I don't have any components:

  • GPIO
  • RFID
  • Buttons

@Groovylein Groovylein marked this pull request as ready for review October 7, 2021 18:11
Copy link
Collaborator

@s-martin s-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MiczFlor MiczFlor merged commit 7b5b956 into MiczFlor:develop Feb 27, 2022
@s-martin s-martin added this to the 2.4 milestone Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 | Remove hardcoded folders and stuff for "pi"
3 participants