Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT configuration is now in a dict for easier management #1609

Merged
merged 3 commits into from
Mar 1, 2022

Conversation

andreasbrett
Copy link
Contributor

Improved usability for configuring the MQTT component based on a comment in the blog post mentioned here #1353 (reply in thread). Settings are now in a dict that allows commenting out unused configuration parameters (like e.g. mqttCA, mqttCert, mqttKey).

Thanks @splitti for the blog post and the hint that this could be improved.

Note: this is branched off of the to-be-merged #1496. Hope both can be merged in the upcoming 2.4 release.

@pabera
Copy link
Collaborator

pabera commented Oct 31, 2021

@andreasbrett Would you also develop the MQTT extension for future3? 🤓

@andreasbrett
Copy link
Contributor Author

andreasbrett commented Oct 31, 2021 via email

@ghost
Copy link

ghost commented Oct 31, 2021

Yes, this is on my list. Will wait a moment until futur3 is a bit less alpha though. Shouldn't be too many modifications but I only want to do it once the code base is more stable.

Great! In Future3 we already have a Publisher Concept for immediate status publishing. No polling involved. So, the only thing a MQTT must do is listen to the publisher and translate the publish messages into the MQTT format. Vice versa for commands from MQTT to RPC. So this is a fair change from the Version 2. Still, it will be relatively easy to integrate. The hard question will be whether to support the "old" MQTT topic names or switch to the topic names of the new Publisher. Once you want to start, feel free to drop me a message in the chat. I could point you to a good starting point (if needed).

@MiczFlor
Copy link
Owner

Hi @andreasbrett
there is one conflict in this pull request now:


                # publish event "card_swiped"
<<<<<<< patch-5
                client.publish(config.get("mqttBaseTopic") + "/event/card_swiped", payload=cardid)
=======
                client.publish(mqttBaseTopic + "/event/card_swiped", payload=cardid)
>>>>>>> develop
                print(" --> Publishing event card_swiped = " + cardid)

@andreasbrett
Copy link
Contributor Author

andreasbrett commented Feb 27, 2022

Hi @andreasbrett there is one conflict in this pull request now:


                # publish event "card_swiped"
<<<<<<< patch-5
                client.publish(config.get("mqttBaseTopic") + "/event/card_swiped", payload=cardid)
=======
                client.publish(mqttBaseTopic + "/event/card_swiped", payload=cardid)
>>>>>>> develop
                print(" --> Publishing event card_swiped = " + cardid)

@MiczFlor this should be fine now

@MiczFlor
Copy link
Owner

MiczFlor commented Mar 1, 2022

Merging -- but I can't test it myself... :) sorry...

@MiczFlor MiczFlor merged commit 5084ace into MiczFlor:develop Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants