Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDM6300 V2: Add separated variables and an additional timeout #193

Merged
merged 7 commits into from
Sep 11, 2018

Conversation

ottk3
Copy link
Contributor

@ottk3 ottk3 commented Sep 11, 2018

This commit moves the device and baudrate (default is used) in additional variables.

It adds a timeout to prevent an infinite loop, if last byte could not be read.

Also added an exception handling vor ValueErrors to prevent to return invalid UUIDs

ottk3 and others added 7 commits September 2, 2018 22:59
…s of the RDM6300 module

Move device and baudrate in additional variables and add a timeout to prevent an infinite loop if last byte could not be read.

Add a self.last_id variable which returns the last read card, if a value exception is raised.
folder link to cards in web ui use path_rel not basepath
…s of the RDM6300 module

Move device and baudrate in additional variables and add a timeout to prevent an infinite loop if last byte could not be read.

Add a self.last_id variable which returns the last read card, if a value exception is raised.
# Conflicts:
#	scripts/Reader_RDM6300.py
@MiczFlor MiczFlor changed the base branch from master to develop September 11, 2018 13:23
@MiczFlor
Copy link
Owner

Hi @ottk3
looking good, I like the error catching and the sleep (which is what I thought immediately when you mentioned the stuttering). Will merge this with develop and it goes live in the next couple of days.

@MiczFlor MiczFlor merged commit 6721824 into MiczFlor:develop Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants