Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop from Release 2.4 into master to fix history #2099

Merged
merged 268 commits into from
Dec 21, 2023

Conversation

AlvinSchiller
Copy link
Collaborator

@AlvinSchiller AlvinSchiller commented Nov 10, 2023

With Release 2.3 and 2.4 the develop branch has been merged into master with a squash. This brings the problem that develop and master don't share the same history anymore and any furter merge from develop to master will show more commits then where actually made.

To fix this situation non invasively, the current master should be merged with the corresponding commit from develop to sync the history again.

develop commit: 7f43f48
There are no file changes so its the same source code state. Its just for syncing history.

Any future release must not be merged with a squash.
Should be merged right before #2030

@s-martin

Schneelocke and others added 30 commits December 1, 2020 20:30
As there is a savepos-command in "playerstop" this should also be included in "playerstopafter".
missing savepos-command in "playerstopafter"
This reverts commit 6d504e5.
Resolving MiczFlor#469 by simplifying collapse IDs in folder tree.
Make use of integers for collapse IDs rather than folder names to avoid
problem with any kind of non-allowed characters as ID value.

Simplifies corresponding code as no character replacement is required
for collapse IDs anymore.
Calendar for 2021 into the readme file
* feat: Buttons USB Encoder

Closes MiczFlor#1156

* change usb to uppercase USB
* web app settings for MiczFlor#1122

* web app settings for MiczFlor#1122

* Include @Toqqi's review comments

Co-authored-by: s-martin <[email protected]>
c0un7-z3r0 and others added 23 commits May 29, 2022 21:26
* fix reportet duration via mqtt

this adjusts the regex to get  the duration attribute from the status object.

* feat: use for duration the fallback time attribute

In some cases mpd does not report the duration of a track in
the mpd status response but usually a rounded value in the time
attribute. So lets use this as fallback value.
…r-Spotify-API-end-of-life

Update README.md
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 3 to 4.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Follow-up for commit "facilitate transition to bullseye".
Bug: Since bullseye uses php7.4, php.ini will not be replaced by the sample
Solution: Read folder name in /etc/php and use it in variable php_ini, keeping compatibility with buster
* Update dockerimage.yml

* Update pythonpackage.yml
* fix flake8 warnings

* fix markdownlint
* feat: add repeat mode to mqtt attributes

* refactor: removes duplicated function

* docs: adds repeat_mode attribute to README

* refactor: extract method outside of main function

* chore: remove more duplicated code
Bumps [php-mock/php-mock-phpunit](https://github.com/php-mock/php-mock-phpunit) from 2.5.0 to 2.6.1.
- [Release notes](https://github.com/php-mock/php-mock-phpunit/releases)
- [Commits](php-mock/php-mock-phpunit@2.5.0...2.6.1)

---
updated-dependencies:
- dependency-name: php-mock/php-mock-phpunit
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 8.5.30 to 9.5.25.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases)
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/main/ChangeLog-8.5.md)
- [Commits](sebastianbergmann/phpunit@8.5.30...9.5.25)

---
updated-dependencies:
- dependency-name: phpunit/phpunit
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix flake8 warnings

* fix markdownlint

* fix markdown lint warnings
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 9.5.25 to 9.5.26.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases)
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/main/ChangeLog-9.5.md)
- [Commits](sebastianbergmann/phpunit@9.5.25...9.5.26)

---
updated-dependencies:
- dependency-name: phpunit/phpunit
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix flake8 warnings

* fix markdownlint

* fix markdown lint warnings

* merge recent updates in install script buster-install-default-with-autohotspot.sh

* fix flake8 warnings

* prepare README.md for 2.4 release and little cleanup
…iczFlor#1903)

* fix flake8 warnings

* fix markdownlint

* fix markdown lint warnings

* merge recent updates in install script buster-install-default-with-autohotspot.sh

* fix flake8 warnings

* dont use pytest-pythonpath anymore (obsolete)

* revert last commit
Merge commit '7f43f484407d6efa89ca45a9a5941d3f439d598a'
@AlvinSchiller AlvinSchiller marked this pull request as ready for review November 10, 2023 10:25
@DivineDominion
Copy link

Any future release must not be merged with a squash.

Maybe it won't hurt to disable this merge strategy completely in the repo settings?

@AlvinSchiller
Copy link
Collaborator Author

AlvinSchiller commented Nov 13, 2023

Any future release must not be merged with a squash.

Maybe it won't hurt to disable this merge strategy completely in the repo settings?

The problem is it would be not allowed for "master", but desired for "develop". And sadly you cant disable "squash and merge" on branch base

@AlvinSchiller
Copy link
Collaborator Author

AlvinSchiller commented Nov 27, 2023

THIS CHANGE MUST BE MADE WITH A PUSH FROM OUTSIDE OF GITHUB WITHOUT A NEW COMMIT.
MERGING THIS PR DOES NOT RESOLVE THE PROBLEM, AS IT CREATES A NEW COMMIT.

@AlvinSchiller AlvinSchiller merged commit 68ff54b into MiczFlor:master Dec 21, 2023
@AlvinSchiller AlvinSchiller mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.