Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve version info #831

Merged
merged 7 commits into from
Mar 23, 2020
Merged

[WIP] Improve version info #831

merged 7 commits into from
Mar 23, 2020

Conversation

s-martin
Copy link
Collaborator

@s-martin s-martin commented Mar 4, 2020

  • save used git commit hash to version file
  • use saved git commit to determine if same version is already installed

see #828

@s-martin s-martin changed the title Improve version info [WIP] Improve version info Mar 5, 2020
@s-martin s-martin requested a review from MiczFlor March 5, 2020 09:24
@s-martin s-martin self-assigned this Mar 8, 2020
@MiczFlor
Copy link
Owner

Hi @s-martin
the conflict reported here by github refers to the installation section for spotify. Not sure which one is the latest version. Looks like the code has moved on? Could you take a look?
I will be more present now, I promise :)

@s-martin
Copy link
Collaborator Author

I fixed the conflict.

The check, if same version is already installed is still missing, but we could add that later.

settings/version Show resolved Hide resolved
@MiczFlor MiczFlor merged commit 53ecb53 into MiczFlor:develop Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 when upgrading - script should detect if the installed version is the current version
3 participants