Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test installation script #925

Merged
merged 2 commits into from
May 3, 2020

Conversation

fredg02
Copy link
Contributor

@fredg02 fredg02 commented May 3, 2020

No description provided.

@fredg02 fredg02 mentioned this pull request May 3, 2020
@MiczFlor MiczFlor merged commit eb32149 into MiczFlor:develop May 3, 2020
@s-martin
Copy link
Collaborator

s-martin commented May 3, 2020

@fredg02, did you try to address the error from https://github.com/MiczFlor/RPi-Jukebox-RFID/runs/640147466 with this PR?
The path where the test script looks for PhonieboxInstall.conf has changed, but the file is still not created/available.

Of course problem could be Docker related, maybe file already deleted again. Should we try, if the test script works on Docker?

@fredg02
Copy link
Contributor Author

fredg02 commented May 3, 2020

@fredg02, did you try to address the error from https://github.com/MiczFlor/RPi-Jukebox-RFID/runs/640147466 with this PR?

No, my intention was to adapt the test script after this change:
https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/develop/scripts/installscripts/buster-install-default.sh#L803-L805

The path where the test script looks for PhonieboxInstall.conf has changed, but the file is still not created/available.

Sorry, that was not intended. The test script should look for the conf file in the home dir. PR #929 should fix this.

Of course problem could be Docker related, maybe file already deleted again. Should we try, if the test script works on Docker?

Let's see if PR #929 fixes it.

@fredg02 fredg02 deleted the fix_test_installation_script branch May 3, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants