Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reach/router dependency conflict #23

Closed
pavittarx opened this issue Oct 7, 2021 · 3 comments
Closed

reach/router dependency conflict #23

pavittarx opened this issue Oct 7, 2021 · 3 comments
Labels
hacktoberfest hacktoberfest-accepted

Comments

@pavittarx
Copy link
Contributor

@MightyJoeW
I got a dependency conflict, when first tried to install this project. I am using npm v7 along. When I tried npm i, it gave me a dependency conflict with reach/router. I digged in a little bit, and found that reach/router is not being maintained as of now.
storybookjs/storybook#14619

Also, since this project is pretty new, switching to react-router would make a lot more sense.
Thanks!
@MightyJoeW
Copy link
Owner

Good point about react-router. I'm open to switching to react-router 👍🏽

@Kapil-Kawathekar
Copy link
Contributor

Hi @MightyJoeW can you assign this to me I will change the route into react-router

Kapil-Kawathekar added a commit to Kapil-Kawathekar/OpenSourceDevs that referenced this issue Oct 8, 2021
@Kapil-Kawathekar
bugFix for MightyJoeW#30 and added react-router for MightyJoeW#23

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c31d08c
This was referenced Oct 8, 2021
Closed
Merged
@Kapil-Kawathekar
Copy link
Contributor

Kapil-Kawathekar commented Oct 11, 2021 •
edited
Loading

Hi @MightyJoeW I have created the PR (#39) for this issue can you take a look and if its ok please merge this PR, Thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MightyJoeW @pavittarx @Kapil-Kawathekar