Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to implement the hideOverlay() function like 2.7.0. I didn't find the relevant API in 3.0.0 #150

Closed
mytianer opened this issue Oct 25, 2024 · 5 comments · Fixed by #160
Closed

How to implement the hideOverlay() function like 2.7.0. I didn't find the relevant API in 3.0.0 #150

mytianer opened this issue Oct 25, 2024 · 5 comments · Fixed by #160

Comments

@mytianer
Copy link

In previous versions, after using hideOverlay(), the view under the popup can still be interacted
@FulcrumOne
Copy link
Contributor

Hey @mytianer,

This option was moved directly into the popup. Use it in the configurePopup method:

CleanShot 2024-10-25 at 10 48 24

CleanShot 2024-10-25 at 10 48 31

@mytianer
Copy link
Author

I have used .overlayColor(.clear) in the new version. But the problem is that the view under the popup cannot be interacted with
截屏2024-10-25 17 05 11

@FulcrumOne
Copy link
Contributor

FulcrumOne commented Oct 25, 2024 •
edited
Loading

Oh, I see. Seems that when designing this functionality, my goal was to catch "tap outside" event rather than interaction with the content. I'll have to rethink this issue, but unfortunately I don't have time to deal with it right now because I'm working on the framework's readme file, which I have to finish by Tuesday.

CleanShot 2024-10-25 at 11 12 31

However you can fix it very easily - just replace .black.opacity(0.0000000001) with .clear (line 78 of PopupView file) and it will work as you want. I'm super sorry for this, but I had completely missed this use case.

Have a nice day,
Tomasz

@mytianer
Copy link
Author

Thank you very much for reply, now it works well

@FulcrumOne FulcrumOne mentioned this issue Nov 17, 2024
Merged
@FulcrumOne FulcrumOne linked a pull request Nov 17, 2024 that will close this issue
Patch 4.0.0 #160
Merged
@FulcrumOne
Copy link
Contributor

Hey @mytianer,

Just letting you know that this feature returned in the version 4.0.0.

Have a nice day,
Tomasz

FulcrumOne added a commit that referenced this issue Nov 17, 2024
@FulcrumOne
Patch 4.0.0
9197026 
perf:
- Improved library performance due to better task distribution between threads (#153)

fix:
- Fixed an issue with calling the library from non-main threads (#147)
- Fixed an issue that made it impossible to interact with the app when the overlay was set to clear (#150)
- Fixed a problem with the stacked popups background color
- Improved vertical popup animations

refactor:
- Renamed and changed some public API properties (see 3.x.x -> 4.0.0 Migration Guide for more information)
- Refactored several smaller files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch 4.0.0 Mijick/Popups
2 participants
@mytianer @FulcrumOne