Test with -race in CI

Attempt to detect race conditions in CI. Make a test timeout longer to account for slower speed with the `-race` flag. Signed-off-by: Michael Smith <[email protected]>
MikaelSmith · Feb 3, 2020 · 382a4f6 · 382a4f6
1 parent 3d9dad3
commit 382a4f6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -14,6 +14,7 @@ env:
 jobs:
   include:
   - name: Test Go stable
+    script: go test -race ./...
   - name: Acceptance tests
     before_script:
     - |

diff --git a/plugin/execCommandImpl_test.go b/plugin/execCommandImpl_test.go
@@ -12,8 +12,8 @@ import (
 
 type ExecCommandImplTestSuite struct {
 	suite.Suite
-	ctx         context.Context
-	cancelFunc  context.CancelFunc
+	ctx        context.Context
+	cancelFunc context.CancelFunc
 }
 
 func (suite *ExecCommandImplTestSuite) SetupTest() {
@@ -89,7 +89,8 @@ func (suite *ExecCommandImplTestSuite) TestNewExecCommand_CancelledContext_Close
 func (suite *ExecCommandImplTestSuite) TestSetStopFunc_CancelledContext_StopsCommand() {
 	execCmd := suite.NewExecCommand()
 	stoppedCh := make(chan bool, 1)
-	time.AfterFunc(1 * time.Second, func() {
+	// Allow lots of time for slow testing with `-race`.
+	time.AfterFunc(10*time.Second, func() {
 		close(stoppedCh)
 	})
 	execCmd.SetStopFunc(func() {
@@ -179,4 +180,3 @@ func (suite *ExecCommandImplTestSuite) TestExitCode_ReturnsExitCodeErrIfSet() {
 func TestExecCommandImpl(t *testing.T) {
 	suite.Run(t, new(ExecCommandImplTestSuite))
 }
-