Skip to content

Commit

Permalink
Make MarkInaccessible issue a warning
Browse files Browse the repository at this point in the history
`MarkInaccessible` is usually marked if something is unavailable,
either because it doesn't exist or you don't have permission to access
it. Either of these can be unexpected, so we should warn when that
happens rather than requiring that you dig into `whistory`.

Signed-off-by: Michael Smith <[email protected]>
  • Loading branch information
MikaelSmith committed Mar 5, 2020
1 parent dc31e76 commit 927d524
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plugin/entryBase.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ func (e *EntryBase) SetPartialMetadata(obj interface{}) *EntryBase {
// MarkInaccessible sets the inaccessible attribute and logs a message about why the entry is
// inaccessible.
func (e *EntryBase) MarkInaccessible(ctx context.Context, err error) {
activity.Record(ctx, "Omitting %v: %v", e.id, err)
activity.Warnf(ctx, "Omitting %v: %v", e.id, err)
e.isInaccessible = true
}

Expand Down

0 comments on commit 927d524

Please sign in to comment.