Panic if plugin root implements delete

Signed-off-by: Enis Inan <[email protected]>

plugin/registry.go

@@ -50,6 +50,11 @@ func (r *Registry) RegisterPlugin(root Root, config map[string]interface{}) erro
 				msg := fmt.Sprintf("r.RegisterPlugin: the %v plugin's already been registered", root.name())
 				panic(msg)
 			}
+
+			if DeleteAction().IsSupportedOn(root) {
+				msg := fmt.Sprintf("r.RegisterPlugin: the %v plugin's root implements delete", root.name())
+				panic(msg)
+			}
 		}
 
 		r.plugins[root.name()] = root

plugin/registry_test.go

@@ -117,6 +117,28 @@ func (suite *RegistryTestSuite) TestRegisterPluginRegisteredPlugin() {
 	suite.Panics(panicFunc, "r.RegisterPlugin: the mine plugin's already been registered")
 }
 
+type mockRootWithDelete struct {
+	*mockRoot
+}
+
+func (m *mockRootWithDelete) Delete(ctx context.Context) error {
+	return nil
+}
+
+func (suite *RegistryTestSuite) TestRegisterPluginPluginRootImplementsDelete() {
+	panicFunc := func() {
+		reg := NewRegistry()
+		m := &mockRootWithDelete{
+			mockRoot: &mockRoot{
+				EntryBase: NewEntry("mine"),
+			},
+		}
+		_ = reg.RegisterPlugin(m, map[string]interface{}{})
+	}
+
+	suite.Panics(panicFunc, "r.RegisterPlugin: the mine plugin's root implements delete")
+}
+
 func TestRegistry(t *testing.T) {
 	suite.Run(t, new(RegistryTestSuite))
 }