Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-468: test_parameters parsing is broken at GdUnitVectorAssertImplTest reports 112✅and 2⚪skipped #468

Closed
MikeSchulze opened this issue May 22, 2024 · 0 comments · Fixed by #476
Closed

GD-468: test_parameters parsing is broken at GdUnitVectorAssertImplTest reports 112✅and 2⚪skipped #468

MikeSchulze opened this issue May 22, 2024 · 0 comments · Fixed by #476
Assignees
@MikeSchulze
Labels
bug Something isn't working
Milestone
v4.3.0

Comments

@MikeSchulze
Copy link
Owner

The used GdUnit4 version

4.3.0 (Pre Release/Master branch)

The used Godot version

v4.2.1.stable.mono.official [b09f793f5]

Operating System

all

Describe the bug

The test_parameters parsing is broken and needs to be reviewed.
image

Steps to Reproduce

Run the res://addons/gdUnit4/test/asserts/GdUnitVectorAssertImplTest.gd

Minimal reproduction project

No response
@MikeSchulze MikeSchulze added the bug Something isn't working label May 22, 2024
@MikeSchulze MikeSchulze added this to the v4.3.0 milestone May 22, 2024
@MikeSchulze MikeSchulze self-assigned this May 22, 2024
@MikeSchulze MikeSchulze changed the title GD-XXX: test_parameters parsing is broken at GdUnitVectorAssertImplTest reports 112✅ and 2⚪ skipped GD-468: test_parameters parsing is broken at GdUnitVectorAssertImplTest reports 112✅and 2⚪skipped May 22, 2024
@MikeSchulze MikeSchulze moved this to In Progress in GdUnit4 May 28, 2024
MikeSchulze added a commit that referenced this issue May 28, 2024
@MikeSchulze
GD-468: Fix prameterized test argument parsing
966e7e7 
# Why
See #468

# What
We first trim the input by removing edges and surrounding brackets and then iterate over possible parameters
@MikeSchulze MikeSchulze mentioned this issue May 28, 2024
Merged
@MikeSchulze MikeSchulze linked a pull request May 28, 2024 that will close this issue
GD-468: Fix prameterized test argument parsing #476
Merged
MikeSchulze added a commit that referenced this issue May 28, 2024
@MikeSchulze
GD-468: Fix prameterized test argument parsing (#476)
7149166 
# Why
See #468

# What
We first trim the input by removing edges and surrounding brackets and
then iterate over possible parameters
@github-project-automation github-project-automation bot moved this from In Progress to Done in GdUnit4 May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeSchulze MikeSchulze

Labels
bug Something isn't working
Projects
GdUnit4
Status: Done
Milestone
v4.3.0
Development

Successfully merging a pull request may close this issue.

GD-468: Fix prameterized test argument parsing MikeSchulze/gdUnit4
1 participant
@MikeSchulze