Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-546: Allow to use the basic assert function un-typed #546

Closed
MikeSchulze opened this issue Jul 22, 2024 · 0 comments · Fixed by #547
Closed

GD-546: Allow to use the basic assert function un-typed #546

MikeSchulze opened this issue Jul 22, 2024 · 0 comments · Fixed by #547
Assignees
@MikeSchulze
Labels
enhancement New feature or request
Milestone
v4.3.4

Comments

@MikeSchulze
Copy link
Owner

MikeSchulze commented Jul 22, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
Actual, we run into a compile error when try to test a Variant vs typed value.
assert_that(3).is_equal("3")
The assertions are type save and do not allow testing an un-typed function result to an expected typed result.

It is legate to have a function with a Variant return type, so assert_that should not test for type safety

Describe the solution you'd like
Improve the assertions to allow using un-typed current values vs expected typed values.

is_null
is_not_null
is_equal
is_not_equal

Describe alternatives you've considered
n/a
@MikeSchulze MikeSchulze added the enhancement New feature or request label Jul 22, 2024
@MikeSchulze MikeSchulze added this to the v4.3.4 milestone Jul 22, 2024
@MikeSchulze MikeSchulze self-assigned this Jul 22, 2024
@MikeSchulze MikeSchulze changed the title Allow to use the basic assert function un-typed GD-546: Allow to use the basic assert function un-typed Jul 22, 2024
@MikeSchulze MikeSchulze moved this to In Progress in GdUnit4 Jul 22, 2024
MikeSchulze added a commit that referenced this issue Jul 22, 2024
@MikeSchulze
GD-546: Allow to test un-types values by assert_that
0168576 
# Why
see #546

# What
- do allow all Variant types for `is_equal` and `is_not_equal` when using the untyped `assert_that`
- changed the fixed typed  `is_equal` and `is_not_equal` to accept Variant type
@MikeSchulze MikeSchulze mentioned this issue Jul 22, 2024
Merged
@MikeSchulze MikeSchulze linked a pull request Jul 22, 2024 that will close this issue
GD-546: Allow to test un-typed values by assert_that #547
Merged
MikeSchulze added a commit that referenced this issue Jul 22, 2024
@MikeSchulze
GD-546: Allow to test un-types values by assert_that
b8377eb 
# Why
see #546

# What
- do allow all Variant types for `is_equal` and `is_not_equal` when using the untyped `assert_that`
- changed the fixed typed  `is_equal` and `is_not_equal` to accept Variant type
MikeSchulze added a commit that referenced this issue Jul 22, 2024
@MikeSchulze
GD-546: Allow to test un-types values by assert_that
f7f05c2 
# Why
see #546

# What
- do allow all Variant types for `is_equal` and `is_not_equal` when using the untyped `assert_that`
- changed the fixed typed  `is_equal` and `is_not_equal` to accept Variant type
MikeSchulze added a commit that referenced this issue Jul 22, 2024
@MikeSchulze
GD-546: Allow to test un-typed values by assert_that (#547)
3edc885 
# Why
see #546

# What
- do allow all Variant types for `is_equal` and `is_not_equal` when
using the un-typed `assert_that`
- changed the fixed typed `is_equal` and `is_not_equal` to accept
Variant type
@github-project-automation github-project-automation bot moved this from In Progress to Done in GdUnit4 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeSchulze MikeSchulze

Labels
enhancement New feature or request
Projects
GdUnit4
Status: Done
Milestone
v4.3.4
Development

Successfully merging a pull request may close this issue.

GD-546: Allow to test un-typed values by assert_that MikeSchulze/gdUnit4
1 participant
@MikeSchulze