Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-517: Fix test discovery guard fails on CSharpScript tests when editing #523

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

MikeSchulze
Copy link
Owner

@MikeSchulze MikeSchulze commented Jun 26, 2024

Why

see #517

What

  • added rebuild cs scripts before run discovery
  • fixed invalid script path resolving by using localize_path to convert cs script paths
  • fixes test suite scanner to run on Script class to accept GDScript and CSharpScript

@MikeSchulze MikeSchulze self-assigned this Jun 26, 2024
@MikeSchulze MikeSchulze added the bug Something isn't working label Jun 26, 2024
@MikeSchulze MikeSchulze changed the title GD-517: Fic test discovery guard fails on CSharpScript tests when edi… GD-517: Fix test discovery guard fails on CSharpScript tests when edi… Jun 26, 2024
@MikeSchulze MikeSchulze changed the title GD-517: Fix test discovery guard fails on CSharpScript tests when edi… GD-517: Fix test discovery guard fails on CSharpScript tests when editing Jun 26, 2024
…ting

# Why
see #517

# What
- added rebuild cs scripts before run discovery
- fixed invalid script path resolving by using `localize_path` to convert cs script paths
- fixes test suite scanner to run on Script class to accept GDScript and CSharpScript
@MikeSchulze MikeSchulze merged commit ed32e64 into master Jun 27, 2024
@MikeSchulze MikeSchulze deleted the GD-517 branch June 27, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-517: Test discovery guard fails on CSharpScript tests when editing
1 participant