This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
Move permission test to the HostActions Hook #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Auth singleton is not fully initialized when loading modules because modules may provide custom user backends which in turn requires the modules to be loaded. Checking for permissions in run.php fails may fail the user is authenticated via Web 2's external backend or any custom user backend. Plus, run.php files should be thin with less logic as possible because they're evaluated on every single request. Of course Web 2 should provide something to only register hooks if specific permissions apply like it's the case for menu entries but this change has not been introduced yet.
|
I still learn every day :) How about a seperate conference for developers or a training? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Auth singleton is not fully initialized when loading modules because
modules may provide custom user backends which in turn requires the
modules to be loaded.
Checking for permissions in run.php may fail if the user is
authenticated via Web 2's external backend or any custom user backend.
Plus, run.php files should be thin with less logic as possible because
they're evaluated on every single request.
Of course Web 2 should provide something to only register hooks if
specific permissions apply like it's the case for menu entries but
this change has not been introduced yet.
Rationale: Icinga/icingaweb2#3470 and Icinga/icingaweb2#3500
refs Icinga/icingaweb2#3470