This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
Better error handling for proxy access mode #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use curl_set_opts - do not initialize $this->auth with an `@` at the end, but pass this directly to curl_opts (bug introduced in 70a61a3) - curl_error($curl_handle) is not a safe error handling when RETURNTRANSFER is set to true (must check for $res === false, http://stackoverflow.com/questions/16452636/php-curl-what-does-curl-exec-return) - fetch the http status code and return an error - add Util class with http status code translation to string - better explanation of `accesscode` in the docs fixes #31 fixes #32
|
PS: If you merge this to master (master is broken atm), I can merge Icinga/icinga-vagrant#59 :-) |
This was referenced Apr 24, 2017
Mikesch-mp
pushed a commit
that referenced
this pull request
May 20, 2017
This also gives a hint for curl_error() == 7 which normally leads to SELinux. Test that on a box with SELinux in enforcing mode. Also fixed error handling of getPreviewImage (renamed to getPreviewHtml). This commit passed the previewHtml variable by reference while returning true/false. This allows to check whether to render the URL or not. Simplified the code in some parts too. refs #33 fixes #35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@at the end, but pass this directly to curl_opts (bug introduced in 70a61a3)accesscodein the docsfixes #31
fixes #32