Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will change the default behavior of PySRRegressor to not update the Julia packages when
.fit
is called. i.e., this will setupdate=False
by default, rather thanupdate=True
. I think this is more in line with what a user would expect - that once they install PySR and runpysr.install()
, all packages will remain static.It is also causing trouble for conda-forge, since the pysr package actually includes all dependencies when first built - if any new dependency is needed, then pysr will break. This fixes #201. cc @ngam.
To update Julia packages, in pip or in conda, you may run
pysr.install()
again, or setupdate=True
.TODO:
pip install -U pysr
without runningpysr.install()
a second time.update
kwarg that the user should make sure their pysr version is up-to-date first, before runninginstall()
- so there aren't any missing packages in the depot.SymbolicRegression.jl
version matches what PySR expects.