Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda forge installs #202

Merged
merged 13 commits into from
Oct 10, 2022
Merged

Fix conda forge installs #202

merged 13 commits into from
Oct 10, 2022

Conversation

MilesCranmer
Copy link
Owner

@MilesCranmer MilesCranmer commented Oct 10, 2022

This will change the default behavior of PySRRegressor to not update the Julia packages when .fit is called. i.e., this will set update=False by default, rather than update=True. I think this is more in line with what a user would expect - that once they install PySR and run pysr.install(), all packages will remain static.

It is also causing trouble for conda-forge, since the pysr package actually includes all dependencies when first built - if any new dependency is needed, then pysr will break. This fixes #201. cc @ngam.

To update Julia packages, in pip or in conda, you may run pysr.install() again, or set update=True.

TODO:

  • Create test for expected behavior when a user runs pip install -U pysr without running pysr.install() a second time.
  • Mention in docstring for update kwarg that the user should make sure their pysr version is up-to-date first, before running install() - so there aren't any missing packages in the depot.
  • Bump version number.
  • Create check that the SymbolicRegression.jl version matches what PySR expects.

@MilesCranmer MilesCranmer linked an issue Oct 10, 2022 that may be closed by this pull request
@MilesCranmer
Copy link
Owner Author

There isn't a clean way to check a Julia package's version right now, so I'll leave that for later. Just added a PACKAGE_VERSION constant to SymbolicRegression.jl, so that can be used in the future.

@MilesCranmer MilesCranmer merged commit 49b163d into master Oct 10, 2022
@MilesCranmer MilesCranmer deleted the fix-conda-forge branch October 10, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] conda version breaking
1 participant