Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegation test #10325

Merged
merged 6 commits into from
Mar 11, 2022
Merged

Delegation test #10325

merged 6 commits into from
Mar 11, 2022

Conversation

QuiteStochastic
Copy link
Contributor

@QuiteStochastic QuiteStochastic commented Mar 2, 2022 •
edited
Loading

write a new delegation test in support of #10319

@QuiteStochastic QuiteStochastic requested review from a team as code owners March 2, 2022 02:44
@QuiteStochastic QuiteStochastic changed the base branch from develop to compatible March 8, 2022 02:06
@QuiteStochastic QuiteStochastic added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 9, 2022
nholland94
nholland94 approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@nholland94 nholland94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, but I'm noticing something about our wait condition implementation that could easily lead to false positives for tests in the future. We can land this, but let's sync up about improving the wait condition implementation.

src/lib/integration_test_lib/wait_condition.ml Show resolved Hide resolved
src/app/test_executive/delegation_test.ml Outdated Show resolved Hide resolved
@QuiteStochastic QuiteStochastic mentioned this pull request Mar 9, 2022
Merged
@QuiteStochastic QuiteStochastic merged commit d2bef7f into compatible Mar 11, 2022
@QuiteStochastic QuiteStochastic deleted the delegation_test branch March 11, 2022 01:08
@QuiteStochastic QuiteStochastic mentioned this pull request Mar 11, 2022
Closed
6 tasks
@QuiteStochastic QuiteStochastic mentioned this pull request May 24, 2022
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nholland94 nholland94 nholland94 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch intg-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuiteStochastic @nholland94