Add bitswap block encoding/decoding to ocaml #10579
Conversation
There was a problem hiding this comment.
Also, what do you think of cross-testing both implementations on random samples of data?
Like, adding a new RPC for testing purposes to query libp2p helper for blocks generated for the data provided.
And then checking that representation by both versions of the code is same.
nholland94
added
the
ci-build-me
| in | ||
| loop ls >>| List.concat | ||
| loop ls (return []) >>| List.rev >>| List.concat |
There was a problem hiding this comment.
Why don't we rewrite above with fold instead of manual recursive loop ?
There was a problem hiding this comment.
Because a fold won't terminate if acc returns error (will continue to iterate regardless). I could use a fold_until instead, but the implementation would be much uglier I fear.
| let size = Bigstring.length chunk in | ||
| last_leaf_block_data_size := | ||
| if !last_leaf_block_data_size = 0 then size | ||
| else min !last_leaf_block_data_size size |
There was a problem hiding this comment.
I understand the logic here, like leaf is the smallest block and for it queue is empty. But use of min strikes my sight, could we get rid of it?
There was a problem hiding this comment.
Although it's just a test and isn't so important.
There was a problem hiding this comment.
Yeah, the min was just the easy way to make this work, since the "last leaf" isn't the last block you traverse here.
nholland94
force-pushed
the
feature/bitswap-block-format-ocaml
branch
from
aed20a9 to
e5daaa6
Compare
Closes #9451.