Bump ppx_version for Jane Street v14 libs
#11067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
added
the
ci-build-me
Firobe
approved these changes
May 24, 2022
mrmr1993
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Binable.Of_binable...with_uuidfunctors, which may produce unstable serializationsBinable.Of_binable...without_uuidfunctorsThe old functor names, that don't mention uuid's, are still in the code, because the docs suggest those are module aliases to the
without_uuidones.Tested by compiling this branch, trying to add a use of
Of_binable_with_uuid, saw the linter warning in Emacs.Closes #11055. Will create another PR against
develop.