Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nix lsp to devShell, improve nix/README.md #11311

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Conversation

balsoft
Copy link
Contributor

@balsoft balsoft commented Jun 16, 2022

Adds an easy way for developers to use the pure Nix build for LSP-enabled editing.

@balsoft balsoft requested a review from Firobe June 16, 2022 11:26
@Firobe Firobe added the Tweag label Jun 16, 2022
Copy link
Contributor

@Firobe Firobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookgs good! Just a few suggestions of improvement here and there.

nix/README.md Outdated Show resolved Hide resolved
nix/README.md Outdated Show resolved Hide resolved
nix/README.md Outdated Show resolved Hide resolved
nix/README.md Outdated Show resolved Hide resolved
nix/README.md Outdated Show resolved Hide resolved
nix/README.md Outdated Show resolved Hide resolved
nix/README.md Outdated Show resolved Hide resolved
nix/README.md Outdated Show resolved Hide resolved
@Firobe Firobe added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jun 16, 2022
Co-authored-by: Virgile Robles <[email protected]>
@balsoft balsoft requested a review from a team as a code owner June 17, 2022 10:23
README-dev.md Show resolved Hide resolved
@balsoft balsoft merged commit 8b74d5c into compatible Jun 20, 2022
@balsoft balsoft deleted the nix-add-lsp branch June 20, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants