Fix timestamp precondition #11577
Merged
Fix timestamp precondition #11577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
added
the
ci-build-me
psteckler
reviewed
Jul 29, 2022
psteckler
reviewed
Jul 29, 2022
src/lib/block_time/block_time.ml
Outdated
| @@ -249,8 +258,14 @@ module Time = struct | |||
|
|
|||
| let to_uint64 : t -> UInt64.t = to_span_since_epoch | |||
|
|
|||
| (* TODO: this serializes the max_value to "-1", which isn't very nice *) | |||
| let to_string = Fn.compose Int64.to_string to_int64 | |||
There was a problem hiding this comment.
same here, an error if negative
psteckler
approved these changes
Aug 1, 2022
MartinMinkov
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Mina part of fixing timestamp preconditions in snarkyjs (o1-labs/o1js#180)
Block_timeto convert fromTime_ns.tIndexed_pool>check_timestamp_predicate, to convert the current time toBlock_timeand compare it against the precondition (instead of converting the precondition toTime_ns.tas before, which has some issues)check_timestamp_predicateto fail if any of the parties has an unsatisfied precondition. The old logic only failed if all parties were invalid.