Add access permission to accounts
#12003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmr1993
added
the
ci-build-me
mrmr1993
force-pushed
the
feature/add-access-permission
branch
from
3f24c25 to
a832cfd
Compare
mrmr1993
force-pushed
the
feature/add-access-permission
branch
from
a832cfd to
66dae59
Compare
bkase
approved these changes
Nov 16, 2022
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
bkase
approved these changes
Jan 3, 2023
| | `Set_delegate -> | ||
| Boolean.true_ | ||
| | `Access -> | ||
| failwith |
There was a problem hiding this comment.
why put a crasher here? seems unsafe?
There was a problem hiding this comment.
There's no sensible default value for access, so this ensures that we call it correctly everywhere.
|
!ci-build-me |
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
accesspermission to accounts, which prohibits zkApp accounts from being accessed if the authorization is incorrect. This ensures that an 'empty update' to e.g. a token zkApp can't be used to pass unauthorized sub-calls.Testing is still TODO; opening this to see if CI finds any glaring errors in existing tests.
Checklist:
Fixes 2-pass transaction application model #12548