Don't check zkApp proofs in the snark if application will fail anyway #12490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-build-me |
3 similar comments
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
mrmr1993
force-pushed
the
feature/early-fail
branch
from
132eb1a to
09f12b6
Compare
|
@deepthiskumar your new changes here seem to have broken the CI, and this change is safe as a standalone -- it weakens the snark constraints, but leaves the current verification alone. I've reverted them and merged develop; your changes are in I'm going to open a follow-up PR that skips the verification of those proofs. |
|
!ci-build-me |
6 tasks
deepthiskumar
approved these changes
Jan 26, 2023
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an alternative approach to #12397. This allows us to skip verification of failed zkApp commands' proofs in both the snark and the block verification logic.
Checklist: