Change version byte for transaction hashes #12651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
mrmr1993
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the version byte for transaction hashes so that new hashes can be distinguished from old ones.
Transaction_hash.hash_signed_command_v1now converts V1 commands to V2, then callshash_signed_command. That's what we'll use for the db migration to produce hashes for existing commands.The module passed to
Make_base58_checkis no longer a "top-tagged" module, since we don't have to maintain compatibility with old hashes. That was the only use of top-tagging forBlake2, so remove that.Replaces #12649, which used a more complex approach to distinguish new hashes.