Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote network pool batch size logs to debug #12846

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

mrmr1993
Copy link
Member

As requested by @lk86, this PR demotes the noisy network pool batcher logs from info to debug, to help clean up the daemon log output.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 requested a review from a team as a code owner March 16, 2023 18:23
@mrmr1993
Copy link
Member Author

!ci-build-me

Copy link
Member

@nholland94 nholland94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These almost could even be "spam" level logs. But debug works well too.

@lk86
Copy link
Contributor

lk86 commented Mar 28, 2023

!ci-build-me

@lk86 lk86 merged commit f936235 into compatible Mar 29, 2023
@lk86 lk86 deleted the feature/debug-logs-in-network-batcher branch March 29, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants