-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(compatible) Improve local precomputed block writing (to individual files) #13236
base: compatible
Are you sure you want to change the base?
(compatible) Improve local precomputed block writing (to individual files) #13236
Conversation
!ci-build-me |
!ci-build-me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should run make reformat
again on this. I noticed that there's some indentation changes.
Reformatted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the UX here looks great, thank you!
…t simple reporting.
This reverts commit c56c11f.
fix typo
update buster
…t have restore command
b164eec
to
ad8097d
Compare
ad8097d
to
b396c19
Compare
Explain your changes:
This PR adds a local precomputed block writing functionality to the daemon. To use it, simply set the new CLI flag
--precomputed-blocks-dir PATH
when you start the daemon. Block names are consistent with the gcloud naming convention{network}-{height}-{state_hash}.json
.The new functionality is only triggered when
PATH
is a Unix directory. Otherwise, a warning will be logged and no block writing happens.CLI flags
--precomputed-blocks-dir
added and--precomputed-blocks-path
is changed to--precomputed-blocks-file
Minor improvements to logging wrt block writing
Explain how you tested your changes: