Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(compatible) Improve local precomputed block writing (to individual files) #13236

Draft
wants to merge 27 commits into
base: compatible
Choose a base branch
from

Conversation

Isaac-DeFrain
Copy link
Contributor

@Isaac-DeFrain Isaac-DeFrain commented May 17, 2023

Explain your changes:

This PR adds a local precomputed block writing functionality to the daemon. To use it, simply set the new CLI flag --precomputed-blocks-dir PATH when you start the daemon. Block names are consistent with the gcloud naming convention {network}-{height}-{state_hash}.json.

  • The new functionality is only triggered when PATH is a Unix directory. Otherwise, a warning will be logged and no block writing happens.

  • CLI flags --precomputed-blocks-dir added and --precomputed-blocks-path is changed to --precomputed-blocks-file

  • Minor improvements to logging wrt block writing

Explain how you tested your changes:

  • I built the mainnet daemon, connected to the network, and confirmed that precomputed blocks were logged to the provided directory as expected.

@Isaac-DeFrain Isaac-DeFrain requested a review from a team as a code owner May 17, 2023 01:09
@Isaac-DeFrain Isaac-DeFrain changed the title Add local precomputed block logging to individual files (compatible) Add local precomputed block logging to individual files May 17, 2023
@Isaac-DeFrain Isaac-DeFrain marked this pull request as draft May 17, 2023 20:36
@Isaac-DeFrain
Copy link
Contributor Author

!ci-build-me

@Isaac-DeFrain Isaac-DeFrain marked this pull request as ready for review May 19, 2023 00:35
@Isaac-DeFrain Isaac-DeFrain changed the title (compatible) Add local precomputed block logging to individual files (compatible) Improve local precomputed block writing (to individual files) May 29, 2023
@Isaac-DeFrain Isaac-DeFrain marked this pull request as draft May 29, 2023 17:51
@Isaac-DeFrain Isaac-DeFrain marked this pull request as ready for review May 29, 2023 20:07
@ghost-not-in-the-shell
Copy link
Contributor

!ci-build-me

Copy link
Contributor

@ghost-not-in-the-shell ghost-not-in-the-shell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should run make reformat again on this. I noticed that there's some indentation changes.

@Isaac-DeFrain
Copy link
Contributor Author

Reformatted

Copy link
Contributor

@lk86 lk86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the UX here looks great, thank you!

@Isaac-DeFrain Isaac-DeFrain marked this pull request as draft April 4, 2024 15:31
@Isaac-DeFrain Isaac-DeFrain force-pushed the precomputed-block-logging-local-compatible branch from b164eec to ad8097d Compare April 4, 2024 17:28
@Isaac-DeFrain Isaac-DeFrain force-pushed the precomputed-block-logging-local-compatible branch from ad8097d to b396c19 Compare April 4, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants