-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move graphql logic into integration_test_lib #13416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
mrmr1993
reviewed
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm but see nits
mrmr1993
approved these changes
Jun 22, 2023
!ci-build-me |
!ci-build-me |
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.zenhub.com/workspaces/velocity-62264fddc441a100183f7f86/issues/gh/minaprotocol/mina/13260
Previously, the only way for the test_executive to send graphql commands to nodes on the lucy testnet was to use the graphql functions in kubernetes_network.ml. However kubenetes_network.ml is within the package
lib/integration_test_cloud_engine
, which would make it inaccessible to any other hypothetical engine which we may want to develop, therefore the new engine would have to reimplement it all from scratch.Therefore I have ported the graphql functions and surrounding logic from
lib/integration_test_cloud_engine/kubernetes_network.ml
tolib/integration_test_lib/graphql_requests.ml
It was a pretty direct port, the only real dependency was that the old functions required that the node be passed to them. That's really quite unnecessary, the functions only really need the Uri of the node, which is how the new functions work.
old:
new: