Don't ban nodes for block created in early catchup #13538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when a node is in early catchup and creates a block, it might be considered worse than root and the node to be banned for gossiping it.
This is especially easy to reproduce in a network with a few large-stake BPs, but may happen in network like mainnet too, with a lower probability.
Discussion of the problem: https://www.notion.so/minaprotocol/Banning-of-recently-bootstrapped-block-producer-dd98f2268c9e4a6eb4cbd7730d3a2865
Solution: if parent of the transition is in root history, do not ban.
Additionally, if we've seen gossip with the parent of transition and its ancestor was in root history, do not ban. This one is implemented heuristically via an LRU cache.
Explain how you tested your changes:
Checklist: