Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge genesis_slot renaming into compatible #14271

Merged
merged 9 commits into from
Nov 27, 2023
Merged

Merge genesis_slot renaming into compatible #14271

merged 9 commits into from
Nov 27, 2023

Conversation

Sventimir
Copy link
Contributor

@Sventimir Sventimir commented Oct 5, 2023 •
edited
Loading

Explain your changes:

Explain how you tested your changes:

  • It doesn't really make any changes, just makes makes merging of another PR possible.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@Sventimir Sventimir self-assigned this Oct 5, 2023
@Sventimir
Copy link
Contributor Author

!ci-build-me

@Sventimir Sventimir marked this pull request as draft October 5, 2023 09:47
@Sventimir Sventimir marked this pull request as ready for review October 5, 2023 09:48
@Sventimir Sventimir mentioned this pull request Oct 5, 2023
Closed
7 tasks
@Sventimir
Copy link
Contributor Author

!ci-build-me

@Sventimir Sventimir marked this pull request as draft October 6, 2023 06:39
@Sventimir Sventimir marked this pull request as ready for review October 6, 2023 07:06
@Sventimir
Copy link
Contributor Author

!ci-build-me

@Sventimir
Copy link
Contributor Author

!ci-build-me

@Sventimir
Copy link
Contributor Author

!ci-build-me

@Sventimir
Copy link
Contributor Author

!ci-build-me

@joaosreis joaosreis self-requested a review October 31, 2023 14:08
@Sventimir
Copy link
Contributor Author

!ci-build-me

@bkase
Copy link
Member

bkase commented Nov 27, 2023

!allowed-for-mainnet

@bkase
Copy link
Member

bkase commented Nov 27, 2023

!approved-for-mainnet

@bkase bkase merged commit cd0e746 into berkeley Nov 27, 2023
1 check passed
@bkase bkase deleted the sventimir/rename-fork-config-genesis-slot-berkeley branch November 27, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaosreis joaosreis joaosreis approved these changes

Assignees

@Sventimir Sventimir

Labels
hard fork MinaFoundation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sventimir @bkase @joaosreis @mrmr1993