Don't timeout if offline or bootstrapping before genesis #14328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-build-me |
|
Could you add to the PR description, how you tested the change? |
Done. / @deepthiskumar |
2 tasks
deepthiskumar
approved these changes
Oct 16, 2023
|
!ci-build-me |
|
!approved-for-mainnet |
|
!ci-build-me |
|
!ci-build-me |
|
!approved-for-mainnet |
|
!ci-build-me |
|
!approved-for-mainnet |
psteckler
deleted the
feature/no-offline-bootstrap-timeouts-before-genesis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we see an
Offlineonline status before genesis, don't restart libp2p or raise a timeout. Similarly, if the active status isBootstrappingbefore genesis, don't set the bootstrap timeout.Also: fixed obsolete comment.
Before this change, verified it was possible to crash the daemon via the
Offline_shutdownexception, by setting the offline timeout and thestabilizeinterval to small values.To test the fix, set the low values for the offline timeout and
stabilizeinterval, disabled theis_seedcheck, set the genesis timestamp to sometime in 2024, and inverted theafter_genesisresult, so that the offline timeout was checked before genesis. Ran that twice, both times the node crashed with theoffline too longerror after a couple of minutes. Then, ranafter_genesisnormally, so that the offline timeout was not checked before genesis, and the node did not crash after running for 10 minutes.