Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resending local txns #15719

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Jun 6, 2024

This PR re-enables the re-broadcast of transactions by re-sending them via GraphQL.

This was tested locally by re-emitting the sample transaction

{
  "signature": "7D6E9CDA6A9A102504F5E77CC7F654DAF9D8CCECDB7FB181B8875D5BFD2DD6387F9D001AB542D503B83584175ACA616D0811ADD0A5786D9426B0A987D853390D",
  "payment": {
    "to": "B62qrG31LHaauEVVah44kUVkPNwzh5LZi9iUJFiBepZuK3tCTFALC8D",
    "from": "B62qrG31LHaauEVVah44kUVkPNwzh5LZi9iUJFiBepZuK3tCTFALC8D",
    "fee": "10000000000",
    "token": "1",
    "nonce": "0",
    "memo": null,
    "amount": "16571009648348",
    "valid_until": "4294967295"
  },
  "stake_delegation": null
}

to mina.exe advanced send-rosetta-transactions against a network using the config file

{
  "genesis": {
    "genesis_state_timestamp": "2024-06-06T12:00:00Z"
  },
  "ledger": {
    "accounts": [
      {
        "pk": "B62qrG31LHaauEVVah44kUVkPNwzh5LZi9iUJFiBepZuK3tCTFALC8D",
        "balance": "100000000.000000000",
        "delegate": "B62qrG31LHaauEVVah44kUVkPNwzh5LZi9iUJFiBepZuK3tCTFALC8D",
        "sk": null
      }
    ]
  }
}

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 requested a review from a team as a code owner June 6, 2024 15:07
@mrmr1993
Copy link
Member Author

mrmr1993 commented Jun 6, 2024

!ci-build-me

@nholland94
Copy link
Member

!approved-for-mainnet

@georgeee
Copy link
Member

georgeee commented Jun 6, 2024

@mrmr1993 could you add description about the problem behind this PR into the issue #15721?

  1. Is rebroadcast loop of transactions non-functioning?
  2. Is it happening for any transaction originated on the Mina node or just some subset of transactions (say, transactions from GraphQL)
  3. If "1" is false, then is this issue about ability to re-send a transaction when it became outdated in the rebroadcast loop of Mina node or after Mina node was restarted?/

@mrmr1993
Copy link
Member Author

mrmr1993 commented Jun 6, 2024

!ci-nightly-me

@mrmr1993
Copy link
Member Author

mrmr1993 commented Jun 6, 2024

This now includes an update to the latest mainnet genesis ledger, so that builds have the correct config available.

@mrmr1993
Copy link
Member Author

mrmr1993 commented Jun 6, 2024

!ci-nightly-me

@mrmr1993
Copy link
Member Author

mrmr1993 commented Jun 6, 2024

@amc-ie amc-ie requested a review from a team as a code owner June 7, 2024 13:17
@amc-ie
Copy link
Member

amc-ie commented Jun 7, 2024

!ci-nightly-me

@amc-ie
Copy link
Member

amc-ie commented Jun 7, 2024

!ci-nightly-me

@mrmr1993 mrmr1993 changed the base branch from berkeley to compatible July 2, 2024 17:40
@mrmr1993
Copy link
Member Author

mrmr1993 commented Jul 2, 2024

!ci-build-me

@mrmr1993 mrmr1993 merged commit d293c8c into compatible Jul 2, 2024
38 checks passed
@mrmr1993 mrmr1993 deleted the feature/allow-resending-local-txns branch July 2, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants