Refactor Mina RPCs (compatible) #15970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
nholland94
force-pushed
the
refactor/mina-rpcs
branch
from
444e46d to
400eac4
Compare
|
!ci-build-me |
nholland94
force-pushed
the
refactor/mina-rpcs
branch
from
400eac4 to
e4f3e1d
Compare
|
!ci-build-me |
mrmr1993
approved these changes
Aug 26, 2024
Comment on lines
+417
to
+429
| (* | ||
| (* setup a proxy response pipe so we can inspect the messages from our test *) | ||
| let proxy_answer_reader, proxy_answer_writer = | ||
| Linear_pipe.create () | ||
| in | ||
| don't_wait_for ( | ||
| Linear_pipe.Reader.iter proxy_answer_reader ~f:(fun answer -> | ||
| if Option.is_none response && is_genesis_state_hash | ||
| ( match response with | ||
| | None when genesis_state_hash -> | ||
| ) | ||
| Linear_pipe.write proxy_response_writer response) | ||
| *) |
|
!ci-build-me |
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Mina RPC implementations such that they are now in a single unified location and have more shared/less duplicated logic.
The first commit is the largest and most annoying to review, but it mostly moves type definitions around and combines RPC implementations that were split across
Mina_networkingandMina_lib. It's intended to have limited behavior changes (the changes that were made are just in standardizing how RPCs are handled). Subsequent commits make more meaningful changes to RPCs, including refactoring the node status system out of the RPC layer (since that was moved over to libp2p_helper some time ago). Further changes will be included in a PR building off of this into develop.