Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lagrange basis performance regression #16261

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix Lagrange basis performance regression #16261

merged 2 commits into from
Oct 21, 2024

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented Oct 18, 2024 •
edited
Loading

@mitschabaude mitschabaude requested a review from a team as a code owner October 18, 2024 19:32
@mitschabaude mitschabaude mentioned this pull request Oct 18, 2024
Closed
@45930
Copy link
Contributor

45930 commented Oct 18, 2024

!ci-build-me

1 similar comment
@mitschabaude
Copy link
Contributor Author

!ci-build-me

@georgeee
Copy link
Member

!ci-build-me

volhovm
volhovm approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@volhovm volhovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. To summarise my understanding: the _maybe_ functions now properly return None when there are no LB in them, which is desirable because on o1js side this code is called in a single-threaded mode, so computing the bases would be undesirably expensive.

@volhovm volhovm merged commit 4f78a48 into compatible Oct 21, 2024
45 checks passed
@volhovm volhovm deleted the fix/return-an-option-when-an-option-is-asked-for branch October 21, 2024 11:58
@45930 45930 mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@querolita querolita querolita approved these changes

@volhovm volhovm volhovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mitschabaude @45930 @georgeee @volhovm @querolita