-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Zkapp_command.Wire.t
#16556
Draft
georgeee
wants to merge
29
commits into
georgeee/proof-cache-tag
Choose a base branch
from
georgeee/user-command-remove-wire-trick
base: georgeee/proof-cache-tag
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove Zkapp_command.Wire.t
#16556
georgeee
wants to merge
29
commits into
georgeee/proof-cache-tag
from
georgeee/user-command-remove-wire-trick
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Transaction_hash.User_command_with_valid_signature
Remove Transaction_hash.User_command_with_valid_signature.Stable
Define stable and regular types separately
Define stable and regular types separately
Contains a few temporary edits to be unwinded later.
Plus: define `generate` and `unwrap` as `Fn.id` in `zkapp_command.ml` and use these definitions in all of the types that depend on `Zkapp_command.t`.
This interface file is an exact copy of the transaction_witness.ml, hence it's redundant to keep it.
This commit is a no-op change, but prepares for the future switch of types.
This is a no-op change which prepares codebase for future switch of zkapp_command types.
This is a no-op modification that is required for future switch of zkapp_command types.
Remainder of changes in preparation of removing hashes from Zkapp_command.Stable.Latest.t.
Use a no-hash representation.
This was referenced Feb 3, 2025
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
Zkapp_command.Wire.t
along with aBinable
-based trick that was used in combination withZkapp_command.Wire.t
to provide serialization forZkapp_command.t
.Motivation for the refactoring lies in the fact that in the previous version hashing code was invoked from the serialization. This is problematic in two ways:
Explain how you tested your changes:
Zkapp_command.Stable.Latest.t
being used instead ofZkapp_command.t
in various places were an error occurs during transaction processingmina advanced verify-commands
has changed, but the old format is still supported with a new optional--legacy
flagChecklist: