Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only forward severity:critical testnet alerts to PagerDuty and add violating condition values to alert descriptions #8182

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Only forward severity:critical testnet alerts to PagerDuty and add violating condition values to alert descriptions #8182

merged 2 commits into from
Mar 16, 2021
+24 −19

Conversation

O1ahmad
Copy link
Contributor

@O1ahmad O1ahmad commented Mar 9, 2021

Test: Buildkite CI

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@O1ahmad O1ahmad requested review from a team March 9, 2021 18:51
@O1ahmad O1ahmad changed the base branch from develop to compatible March 9, 2021 18:51
@O1ahmad O1ahmad changed the title only forward severity:critical alerts to PagerDuty and add violating condition values to alert descriptions Only forward severity:critical testnet alerts to PagerDuty and add violating condition values to alert descriptions Mar 9, 2021
@O1ahmad O1ahmad added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 10, 2021
@O1ahmad O1ahmad requested review from imeckler and removed request for imeckler March 10, 2021 20:50
lk86
lk86 approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@lk86 lk86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once the conflicts are resolved

mrmr1993
mrmr1993 approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mrmr1993 mrmr1993 merged commit 9782092 into compatible Mar 16, 2021
@mrmr1993 mrmr1993 deleted the alert_updates branch March 16, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lk86 lk86 lk86 approved these changes

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@O1ahmad @mrmr1993 @lk86