Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial] Improve error message from missing --generate-genesis-proof #8203

Merged
merged 2 commits into from
Mar 22, 2021
Merged

[Trivial] Improve error message from missing --generate-genesis-proof #8203

merged 2 commits into from
Mar 22, 2021

Conversation

mrmr1993
Copy link
Member

This now prints


FATAL ERROR

  ☠  Coda Daemon encountered a configuration error generating a genesis proof.

Hint: pass the flag --generate-genesis-proof true. For example,
mina.exe daemon --generate-genesis-proof true

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #8093

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 10, 2021
@mrmr1993 mrmr1993 requested a review from a team as a code owner March 10, 2021 20:56
@mrmr1993 mrmr1993 changed the base branch from develop to compatible March 10, 2021 20:58
psteckler
psteckler approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@psteckler psteckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

@aneesharaines
Copy link
Contributor

!approved-for-mainnet

@mrmr1993 mrmr1993 merged commit cdc4472 into compatible Mar 22, 2021
@mrmr1993 mrmr1993 deleted the feature/generate-genesis-proof-flag-missing-error-better branch March 22, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteckler psteckler psteckler approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing -generate-genesis-proof flag throws an ugly error
3 participants
@mrmr1993 @aneesharaines @psteckler